Prompt the user when the invited MatrixId is not recognized #8483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostyle
requested review from
a team,
ganfra and
giomfo
and removed request for
a team
yostyle
force-pushed
the
yostyle/prompt_unrecognized_mxid
branch
2 times, most recently
from
84d6620 to
8712845
Compare
giomfo
approved these changes
May 31, 2023
yostyle
requested review from
a team and
bmarty
and removed request for
ganfra and
a team
bmarty
approved these changes
Jun 1, 2023
| @@ -2741,6 +2743,8 @@ | |||
| <item quantity="other">Invitations sent to %1$s and %2$d more</item> | |||
| </plurals> | |||
| <string name="invite_users_to_room_failure">We could not invite users. Please check the users you want to invite and try again.</string> | |||
| <string name="invite_unknow_users_dialog_content">Unable to find profiles for the Matrix IDs listed below. Would you like to invite them anyway?\n\n%s</string> | |||
| <string name="invite_unknow_users_dialog_submit">Invite anyway</string> | |||
There was a problem hiding this comment.
There is a small typo: unknow -> unknown for the 4 string keys.
yostyle
force-pushed
the
yostyle/prompt_unrecognized_mxid
branch
from
5e532bf to
466f200
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
#8468
Screenshots / GIFs
Tests
Tested devices
Checklist