Add RTL support to RemoveJitsiWidgetView #8235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This PR adds RTL support to
RemoveJitsiWidgetView
as the original code did not seem to consider RTL.In RTL,
translationX
can be a negative value since it slides from right to left.Therefore I updated
translationX
calculation logic so that it can accept negative value in RTL.Additionally, I modified the activation threshold check logic to use the absolute value of
translationX
since it can be negative in RTL.Motivation and context
Fix #8210
Screenshots / GIFs
Before
222949552-da8bcdb4-8ca5-4ca2-871d-9d1d9d8b3731.1.mp4
After
RTL
Screen_Recording_20230311_163816_Element.dbg.mp4
LTR
Screen_Recording_20230321_193157_Element.dbg.mp4
Tests
removeJitsiWidgetView
to slide to end a call.Tested devices
Checklist