Skip to content

Fix: cannot select text in plain text mode in Rich Text Editor #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jan 30, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Hides the container for the rich text menu instead of the rich text menu instead. This should prevent the invisible HorizontalScrollView from overlapping with the EditText and intercepting touch events.
  • Also removes a minHeight value from styles that's no longer needed.

Motivation and context

Fixes #7801 .

Tests

  • Enable the Rich Text Editor in Settings > Labs.
  • Open a room.
  • Tap on the + icon, disable 'Text formatting' option at the bottom.
  • Write some text (it's even better if it has several lines) and then try to select any point of it.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jmartinesp jmartinesp requested review from a team and ganfra and removed request for a team January 30, 2023 11:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit ba7ee68 into develop Feb 7, 2023
@bmarty bmarty deleted the jmartinesp/fix/rte-cant-select-text-in-plain-text-mode branch February 7, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Editor: Cannot select text in certain cases.
3 participants