Skip to content

Voice Broadcast - Fix playback scrubbing not working if playback is stopped #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

Florian14
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix voice broadcast listening not starting from the saved position.

Motivation and context

Fix #7961

Screenshots / GIFs

Tests

  • Move the cursor of the seek bar of a voice broadcast
  • Press the play button
  • Then the playback should be started from the cursor position

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 960bb77

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 requested review from a team and bmarty and removed request for a team January 19, 2023 12:53
@Florian14 Florian14 added A-Voice Broadcast Broadcast-style voice messages Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Jan 19, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Florian14 Florian14 merged commit f498fe6 into develop Jan 23, 2023
@Florian14 Florian14 deleted the bugfix/fre/fix_vb_scrubbing branch January 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice Broadcast Broadcast-style voice messages Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice Broadcast - Playback scrubbing does not work if the playback is stopped
3 participants