Skip to content

[Rich text editor] Update list item bullet appearance #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Jan 10, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Update the list item bullet appearance in the rich text editor.

Motivation and context

PSU-1063

Screenshots / GIFs

Before After
bullet-before bullet-after

Tests

  • Enable the rich text editor in labs
  • Start typing a message
  • Tap the bullet list button
  • Note the appearance of the bullets

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew force-pushed the feat/PSU-1063-bullet-size branch from 0384c1b to b73eb1d Compare January 10, 2023 13:50
@jonnyandrew jonnyandrew marked this pull request as ready for review January 10, 2023 13:51
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against b73eb1d

1 similar comment
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against b73eb1d

@jonnyandrew jonnyandrew requested review from a team, bmarty and callumu and removed request for a team January 10, 2023 14:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyandrew jonnyandrew merged commit b7073cb into develop Jan 10, 2023
@jonnyandrew jonnyandrew deleted the feat/PSU-1063-bullet-size branch January 10, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants