fix 7870 #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bmarty merged 2 commits into develop from feature/bca/fix_7870

Jan 2, 2023

Member

BillCarsonFr commented Dec 31, 2022 •

edited

Loading

Type of change

Bugfix

Content

Fixes #7870

Motivation and context

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

ElementBot commented Dec 31, 2022

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 549b383

ElementBot reviewed

View reviewed changes

...oid/src/main/java/org/matrix/android/sdk/internal/session/room/create/CreateLocalRoomTask.kt Show resolved Hide resolved


          fix 7870

a345c6c

BillCarsonFr force-pushed the feature/bca/fix_7870 branch from 549b383 to a345c6c Compare

December 31, 2022 12:22

ElementBot commented Dec 31, 2022

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against a345c6c

BillCarsonFr requested a review from bmarty

January 2, 2023 08:09

bmarty reviewed

View reviewed changes

changelog.d/7870.bugfix Outdated Show resolved Hide resolved


          Fix typo in changelog.

b6258cf

ElementBot commented Jan 2, 2023

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against b6258cf

sonarqubecloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

bmarty merged commit e0c2dc0 into develop

bmarty deleted the feature/bca/fix_7870 branch

January 2, 2023 10:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet