Skip to content

fix bug when create direct room #7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bagvand
Copy link

@bagvand bagvand commented Dec 11, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

before this fix you can not create direct chat.

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Dec 12, 2022
@bmarty
Copy link
Member

bmarty commented Dec 12, 2022

Hello @bagvand thanks for the proposal. Can you add more context about the issue you are encountering (without your fix)?

@bagvand
Copy link
Author

bagvand commented Dec 13, 2022

Hi @bmarty
when we are using awaitTransaction then transaction will be blocked and nothing happen after awaitTransaction.
maybe we have starvation in transaction when using awaitTransaction.

@bagvand
Copy link
Author

bagvand commented Dec 13, 2022

Steps to repro:
1 - Go to "Start Chat"
2 - Choose someone you haven't chatted with him before.
3- Loading will be shown and no dismiss(starvation in transaction of saving user profile)

@bmarty
Copy link
Member

bmarty commented Dec 13, 2022

(Thanks. I do not repro your issue here)

@bagvand
Copy link
Author

bagvand commented Dec 13, 2022

Screen_Recording_20221213-203027_Element.mp4

@bagvand
Copy link
Author

bagvand commented Dec 13, 2022

It will happen when selecting someone in contacts book.

@bmarty
Copy link
Member

bmarty commented Jan 10, 2023

OK, thanks. The issue has been fixed by #7870, which is in Element 1.5.18.

@bmarty bmarty closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants