Skip to content

ANR on session start when sending client info is enabled #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Launch the sending of client info in a dedicated coroutine so that it does not block the main thread on app startup and leads to ANR.

Motivation and context

Closes #7604

Screenshots / GIFs

Tests

  • Enable the labs flag about "Client info recording" in a previous version of the app
  • Update the app with this fix
  • The app should not block on startup

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review November 17, 2022 16:16
@mnaturel mnaturel requested review from a team and jmartinesp and removed request for a team November 17, 2022 16:20
@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label Nov 17, 2022
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnaturel mnaturel force-pushed the fix/mna/anr-on-session-start branch from 6dc3693 to 74c945b Compare November 17, 2022 16:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit cf5b96f into develop Nov 18, 2022
@mnaturel mnaturel deleted the fix/mna/anr-on-session-start branch November 18, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANR on session start when sending client info is enabled
2 participants