Voice Broadcast - Add seek bar with basic implementation #7494

Florian14 · 2022-10-31T14:29:26Z

Type of change

WIP Feature
Bugfix
Technical
Other :

Content

Add a seekBar in the voice broadcast listening tiles with the total duration.
For the moment, the tick is not updated according to the listening progress but helps to navigate into the voice broadcast.

Motivation and context

Continue #7127

Screenshots / GIFs

Tests

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the ~~develop~~ resilience-rc branch
Pull request includes a new file under ./changelog.d. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Florian14 · 2022-10-31T14:35:12Z

.../im/vector/app/features/home/room/detail/timeline/item/MessageVoiceBroadcastListeningItem.kt

+            fastBackwardButton.isInvisible = true
+            fastForwardButton.isInvisible = true


These buttons will be plugged in the following devs

jmartinesp · 2022-10-31T15:14:25Z

Just testing the functionality, I'll take a look at the code next:

The buffering UX again seems weird. It goes from a play button to a short-lived progress bar, then to a reload button that does nothing. When there is some actual data to be played, the button goes back to a pause icon and it actually plays the stream.
The seekbar / progressbar doesn't move? If I play the stream, then move the seekbar, I'd expect it to advance as it plays the stream.

Florian14 · 2022-10-31T15:21:29Z

Just testing the functionality, I'll take a look at the code next:

* The buffering UX again seems weird. It goes from a play button to a short-lived progress bar, then to a reload button that does nothing. When there is some actual data to be played, the button goes back to a pause icon and it actually plays the stream.

I will focus my tests on this issue just now, it's my new priority.

* The seekbar / progressbar doesn't move? If I play the stream, then move the seekbar, I'd expect it to advance as it plays the stream.

Yes, it's a very basic implementation, I decided to focus the development on the functional part given the short deadline. I'll try to have a look at the progress but not sure to have it quickly.

jmartinesp · 2022-10-31T15:23:33Z

I will focus my tests on this issue just now, it's my new priority.

Do you want to address this in another PR? Also, when the stream finishes playing the same reload/restart icon appears, but clicking it does nothing (the whole list item receives the click).

jmartinesp

LGTM assuming the 'restart' icon issues will be handled in a different PR. Just a little nitpick.

jmartinesp · 2022-10-31T15:15:46Z

...rc/main/java/im/vector/app/features/home/room/detail/timeline/helper/TimelineEventsGroups.kt

@@ -148,4 +149,8 @@ class VoiceBroadcastEventsGroup(private val group: TimelineEventsGroup) {
        return group.events.find { it.root.asVoiceBroadcastEvent()?.content?.voiceBroadcastState == VoiceBroadcastState.STOPPED }
                ?: group.events.filter { it.root.type == VoiceBroadcastConstants.STATE_ROOM_VOICE_BROADCAST_INFO }.maxBy { it.root.originServerTs ?: 0L }
    }
+
+    fun getDuration(): Int {
+        return group.events.mapNotNull { it.root.asMessageAudioEvent()?.duration }.reduceOrNull { acc, duration -> acc + duration } ?: 0


I think this reduceOrNull could be replaced with sum().

Indeed, why looking for complicated :)

Florian14 · 2022-10-31T16:12:47Z

@jmartinesp I finally did a quick implementation of the live seek bar update

jmartinesp · 2022-10-31T16:18:23Z

@jmartinesp I finally did a quick implementation of the live seek bar update

I think it's probably better to revert it for now, at seems to break live streaming. As soon as new chunks arrive, the seekbar gets updated and the media player seems to get in a weird state where it's waiting for new chunks although it should have enough data already in the buffer.

Florian14 · 2022-10-31T16:25:16Z

@jmartinesp I finally did a quick implementation of the live seek bar update

I think it's probably better to revert it for now, at seems to break live streaming. As soon as new chunks arrive, the seekbar gets updated and the media player seems to get in a weird state where it's waiting for new chunks although it should have enough data already in the buffer.

Yeah, I've removed the commit and will work on it on a new branch while investigating the live behaviour

ElementBot · 2022-11-02T16:49:52Z

vector/src/main/res/drawable/ic_player_backward_30.xml

+    android:viewportWidth="24"
+    android:viewportHeight="24">
+  <path
+      android:pathData="M11.976,23.15C9.328,23.15 7.054,22.27 5.156,20.511C3.258,18.751 2.207,16.575 2.003,13.982C1.984,13.76 2.054,13.566 2.211,13.399C2.369,13.232 2.568,13.149 2.809,13.149C3.031,13.149 3.221,13.227 3.378,13.385C3.536,13.542 3.633,13.741 3.67,13.982C3.874,16.112 4.762,17.895 6.337,19.33C7.911,20.765 9.791,21.483 11.976,21.483C14.291,21.483 16.259,20.673 17.88,19.052C19.5,17.432 20.311,15.464 20.311,13.149C20.311,10.834 19.524,8.866 17.949,7.245C16.375,5.625 14.43,4.814 12.115,4.814H11.504L12.949,6.259C13.115,6.426 13.199,6.62 13.199,6.842C13.199,7.065 13.115,7.259 12.949,7.426C12.782,7.593 12.587,7.676 12.365,7.676C12.143,7.676 11.948,7.593 11.782,7.426L8.865,4.509C8.772,4.416 8.707,4.324 8.67,4.231C8.633,4.138 8.615,4.037 8.615,3.925C8.615,3.814 8.633,3.712 8.67,3.62C8.707,3.527 8.772,3.435 8.865,3.342L11.81,0.397C11.958,0.249 12.143,0.175 12.365,0.175C12.587,0.175 12.782,0.249 12.949,0.397C13.097,0.564 13.171,0.758 13.171,0.981C13.171,1.203 13.097,1.388 12.949,1.536L11.337,3.148H11.976C13.365,3.148 14.666,3.407 15.88,3.925C17.093,4.444 18.153,5.157 19.06,6.065C19.968,6.972 20.681,8.032 21.2,9.246C21.718,10.459 21.977,11.76 21.977,13.149C21.977,14.538 21.718,15.839 21.2,17.052C20.681,18.265 19.968,19.325 19.06,20.233C18.153,21.14 17.093,21.854 15.88,22.372C14.666,22.891 13.365,23.15 11.976,23.15Z"


⚠️ Very long vector path (1312 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️ Very long vector path (1312 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

ElementBot · 2022-11-02T16:49:52Z

vector/src/main/res/drawable/ic_player_backward_30.xml

+      android:pathData="M11.976,23.15C9.328,23.15 7.054,22.27 5.156,20.511C3.258,18.751 2.207,16.575 2.003,13.982C1.984,13.76 2.054,13.566 2.211,13.399C2.369,13.232 2.568,13.149 2.809,13.149C3.031,13.149 3.221,13.227 3.378,13.385C3.536,13.542 3.633,13.741 3.67,13.982C3.874,16.112 4.762,17.895 6.337,19.33C7.911,20.765 9.791,21.483 11.976,21.483C14.291,21.483 16.259,20.673 17.88,19.052C19.5,17.432 20.311,15.464 20.311,13.149C20.311,10.834 19.524,8.866 17.949,7.245C16.375,5.625 14.43,4.814 12.115,4.814H11.504L12.949,6.259C13.115,6.426 13.199,6.62 13.199,6.842C13.199,7.065 13.115,7.259 12.949,7.426C12.782,7.593 12.587,7.676 12.365,7.676C12.143,7.676 11.948,7.593 11.782,7.426L8.865,4.509C8.772,4.416 8.707,4.324 8.67,4.231C8.633,4.138 8.615,4.037 8.615,3.925C8.615,3.814 8.633,3.712 8.67,3.62C8.707,3.527 8.772,3.435 8.865,3.342L11.81,0.397C11.958,0.249 12.143,0.175 12.365,0.175C12.587,0.175 12.782,0.249 12.949,0.397C13.097,0.564 13.171,0.758 13.171,0.981C13.171,1.203 13.097,1.388 12.949,1.536L11.337,3.148H11.976C13.365,3.148 14.666,3.407 15.88,3.925C17.093,4.444 18.153,5.157 19.06,6.065C19.968,6.972 20.681,8.032 21.2,9.246C21.718,10.459 21.977,11.76 21.977,13.149C21.977,14.538 21.718,15.839 21.2,17.052C20.681,18.265 19.968,19.325 19.06,20.233C18.153,21.14 17.093,21.854 15.88,22.372C14.666,22.891 13.365,23.15 11.976,23.15Z"
+      android:fillColor="#737D8C"/>
+  <path
+      android:pathData="M9.017,17.09C8.557,17.09 8.148,17.011 7.79,16.853C7.434,16.695 7.153,16.476 6.946,16.195C6.739,15.913 6.63,15.588 6.617,15.22H7.819C7.829,15.397 7.888,15.551 7.994,15.683C8.101,15.813 8.243,15.914 8.419,15.987C8.596,16.059 8.794,16.096 9.014,16.096C9.248,16.096 9.456,16.055 9.637,15.974C9.818,15.891 9.96,15.776 10.062,15.629C10.164,15.482 10.215,15.313 10.212,15.121C10.215,14.923 10.163,14.748 10.059,14.597C9.955,14.445 9.803,14.327 9.605,14.242C9.409,14.157 9.173,14.114 8.896,14.114H8.317V13.2H8.896C9.124,13.2 9.323,13.16 9.493,13.082C9.666,13.003 9.801,12.892 9.899,12.749C9.997,12.604 10.045,12.437 10.043,12.248C10.045,12.062 10.004,11.901 9.918,11.765C9.835,11.626 9.717,11.519 9.564,11.442C9.412,11.365 9.234,11.327 9.03,11.327C8.83,11.327 8.644,11.363 8.474,11.436C8.303,11.508 8.166,11.611 8.061,11.746C7.957,11.878 7.902,12.035 7.895,12.219H6.754C6.763,11.852 6.868,11.531 7.071,11.254C7.275,10.974 7.548,10.757 7.889,10.602C8.23,10.444 8.612,10.365 9.036,10.365C9.473,10.365 9.852,10.447 10.174,10.611C10.498,10.773 10.748,10.991 10.925,11.266C11.102,11.541 11.19,11.845 11.19,12.177C11.193,12.546 11.084,12.855 10.864,13.104C10.647,13.353 10.361,13.516 10.008,13.593V13.644C10.468,13.708 10.821,13.879 11.066,14.156C11.313,14.43 11.435,14.772 11.433,15.182C11.433,15.548 11.329,15.876 11.12,16.166C10.913,16.454 10.628,16.679 10.264,16.843C9.901,17.007 9.486,17.09 9.017,17.09ZM14.515,17.125C13.989,17.125 13.537,16.992 13.16,16.725C12.785,16.457 12.496,16.07 12.294,15.565C12.094,15.058 11.993,14.447 11.993,13.734C11.996,13.02 12.097,12.413 12.297,11.912C12.5,11.409 12.788,11.026 13.163,10.761C13.54,10.497 13.991,10.365 14.515,10.365C15.039,10.365 15.49,10.497 15.867,10.761C16.244,11.026 16.533,11.409 16.733,11.912C16.936,12.415 17.037,13.022 17.037,13.734C17.037,14.45 16.936,15.061 16.733,15.568C16.533,16.073 16.244,16.459 15.867,16.725C15.492,16.992 15.041,17.125 14.515,17.125ZM14.515,16.124C14.924,16.124 15.247,15.923 15.483,15.52C15.722,15.115 15.842,14.52 15.842,13.734C15.842,13.214 15.787,12.777 15.679,12.423C15.57,12.07 15.416,11.803 15.218,11.624C15.02,11.443 14.786,11.353 14.515,11.353C14.108,11.353 13.786,11.555 13.55,11.96C13.313,12.363 13.194,12.954 13.192,13.734C13.19,14.256 13.242,14.695 13.349,15.05C13.457,15.406 13.611,15.675 13.809,15.856C14.007,16.035 14.242,16.124 14.515,16.124Z"


⚠️ Very long vector path (2331 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️ Very long vector path (2331 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

ElementBot · 2022-11-02T16:49:52Z

vector/src/main/res/drawable/ic_player_forward_30.xml

+    android:viewportWidth="24"
+    android:viewportHeight="24">
+  <path
+      android:pathData="M12.001,23.15C14.65,23.15 16.923,22.27 18.822,20.511C20.72,18.751 21.771,16.575 21.975,13.982C21.993,13.76 21.924,13.566 21.766,13.399C21.609,13.232 21.41,13.149 21.169,13.149C20.947,13.149 20.757,13.227 20.6,13.385C20.442,13.542 20.345,13.741 20.308,13.982C20.104,16.112 19.215,17.895 17.641,19.33C16.066,20.765 14.187,21.483 12.001,21.483C9.686,21.483 7.718,20.673 6.098,19.052C4.477,17.432 3.667,15.464 3.667,13.149C3.667,10.834 4.454,8.866 6.028,7.245C7.603,5.625 9.547,4.814 11.862,4.814H12.474L11.029,6.259C10.862,6.426 10.779,6.62 10.779,6.842C10.779,7.065 10.862,7.259 11.029,7.426C11.196,7.593 11.39,7.676 11.612,7.676C11.835,7.676 12.029,7.593 12.196,7.426L15.113,4.509C15.205,4.416 15.27,4.324 15.307,4.231C15.344,4.138 15.363,4.037 15.363,3.925C15.363,3.814 15.344,3.712 15.307,3.62C15.27,3.527 15.205,3.435 15.113,3.342L12.168,0.397C12.02,0.249 11.835,0.175 11.612,0.175C11.39,0.175 11.196,0.249 11.029,0.397C10.881,0.564 10.807,0.758 10.807,0.981C10.807,1.203 10.881,1.388 11.029,1.536L12.64,3.148H12.001C10.612,3.148 9.311,3.407 8.098,3.925C6.885,4.444 5.825,5.157 4.917,6.065C4.01,6.972 3.297,8.032 2.778,9.246C2.259,10.459 2,11.76 2,13.149C2,14.538 2.259,15.839 2.778,17.052C3.297,18.265 4.01,19.325 4.917,20.233C5.825,21.14 6.885,21.854 8.098,22.372C9.311,22.891 10.612,23.15 12.001,23.15Z"


⚠️ Very long vector path (1307 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️ Very long vector path (1307 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

ElementBot · 2022-11-02T16:49:52Z

vector/src/main/res/drawable/ic_player_forward_30.xml

+      android:pathData="M12.001,23.15C14.65,23.15 16.923,22.27 18.822,20.511C20.72,18.751 21.771,16.575 21.975,13.982C21.993,13.76 21.924,13.566 21.766,13.399C21.609,13.232 21.41,13.149 21.169,13.149C20.947,13.149 20.757,13.227 20.6,13.385C20.442,13.542 20.345,13.741 20.308,13.982C20.104,16.112 19.215,17.895 17.641,19.33C16.066,20.765 14.187,21.483 12.001,21.483C9.686,21.483 7.718,20.673 6.098,19.052C4.477,17.432 3.667,15.464 3.667,13.149C3.667,10.834 4.454,8.866 6.028,7.245C7.603,5.625 9.547,4.814 11.862,4.814H12.474L11.029,6.259C10.862,6.426 10.779,6.62 10.779,6.842C10.779,7.065 10.862,7.259 11.029,7.426C11.196,7.593 11.39,7.676 11.612,7.676C11.835,7.676 12.029,7.593 12.196,7.426L15.113,4.509C15.205,4.416 15.27,4.324 15.307,4.231C15.344,4.138 15.363,4.037 15.363,3.925C15.363,3.814 15.344,3.712 15.307,3.62C15.27,3.527 15.205,3.435 15.113,3.342L12.168,0.397C12.02,0.249 11.835,0.175 11.612,0.175C11.39,0.175 11.196,0.249 11.029,0.397C10.881,0.564 10.807,0.758 10.807,0.981C10.807,1.203 10.881,1.388 11.029,1.536L12.64,3.148H12.001C10.612,3.148 9.311,3.407 8.098,3.925C6.885,4.444 5.825,5.157 4.917,6.065C4.01,6.972 3.297,8.032 2.778,9.246C2.259,10.459 2,11.76 2,13.149C2,14.538 2.259,15.839 2.778,17.052C3.297,18.265 4.01,19.325 4.917,20.233C5.825,21.14 6.885,21.854 8.098,22.372C9.311,22.891 10.612,23.15 12.001,23.15Z"
+      android:fillColor="#737D8C"/>
+  <path
+      android:pathData="M9.017,17.09C8.557,17.09 8.148,17.011 7.79,16.853C7.434,16.695 7.153,16.476 6.946,16.195C6.739,15.913 6.63,15.588 6.617,15.22H7.819C7.829,15.397 7.888,15.551 7.994,15.683C8.101,15.813 8.243,15.914 8.419,15.987C8.596,16.059 8.794,16.096 9.014,16.096C9.248,16.096 9.456,16.055 9.637,15.974C9.818,15.891 9.96,15.776 10.062,15.629C10.164,15.482 10.215,15.313 10.212,15.121C10.215,14.923 10.163,14.748 10.059,14.597C9.955,14.445 9.803,14.327 9.605,14.242C9.409,14.157 9.173,14.114 8.896,14.114H8.317V13.2H8.896C9.124,13.2 9.323,13.16 9.493,13.082C9.666,13.003 9.801,12.892 9.899,12.749C9.997,12.604 10.045,12.437 10.043,12.248C10.045,12.062 10.004,11.901 9.918,11.765C9.835,11.626 9.717,11.519 9.564,11.442C9.412,11.365 9.234,11.327 9.03,11.327C8.83,11.327 8.644,11.363 8.474,11.436C8.303,11.508 8.166,11.611 8.061,11.746C7.957,11.878 7.902,12.035 7.895,12.219H6.754C6.763,11.852 6.868,11.531 7.071,11.254C7.275,10.974 7.548,10.757 7.889,10.602C8.23,10.444 8.612,10.365 9.036,10.365C9.473,10.365 9.852,10.447 10.174,10.611C10.498,10.773 10.748,10.991 10.925,11.266C11.102,11.541 11.19,11.845 11.19,12.177C11.193,12.546 11.084,12.855 10.864,13.104C10.647,13.353 10.361,13.516 10.008,13.593V13.644C10.468,13.708 10.821,13.879 11.066,14.156C11.313,14.43 11.435,14.772 11.433,15.182C11.433,15.548 11.329,15.876 11.12,16.166C10.913,16.454 10.628,16.679 10.264,16.843C9.901,17.007 9.486,17.09 9.017,17.09ZM14.515,17.125C13.989,17.125 13.537,16.992 13.16,16.725C12.785,16.457 12.496,16.07 12.294,15.565C12.094,15.058 11.993,14.447 11.993,13.734C11.996,13.02 12.097,12.413 12.297,11.912C12.5,11.409 12.788,11.026 13.163,10.761C13.54,10.497 13.991,10.365 14.515,10.365C15.039,10.365 15.49,10.497 15.867,10.761C16.244,11.026 16.533,11.409 16.733,11.912C16.936,12.415 17.037,13.022 17.037,13.734C17.037,14.45 16.936,15.061 16.733,15.568C16.533,16.073 16.244,16.459 15.867,16.725C15.492,16.992 15.041,17.125 14.515,17.125ZM14.515,16.124C14.924,16.124 15.247,15.923 15.483,15.52C15.722,15.115 15.842,14.52 15.842,13.734C15.842,13.214 15.787,12.777 15.679,12.423C15.57,12.07 15.416,11.803 15.218,11.624C15.02,11.443 14.786,11.353 14.515,11.353C14.108,11.353 13.786,11.555 13.55,11.96C13.313,12.363 13.194,12.954 13.192,13.734C13.19,14.256 13.242,14.695 13.349,15.05C13.457,15.406 13.611,15.675 13.809,15.856C14.007,16.035 14.242,16.124 14.515,16.124Z"


⚠️ Very long vector path (2331 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️ Very long vector path (2331 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

sonarqubecloud · 2022-11-02T16:53:48Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

1.3% Coverage
0.0% Duplication

Florian14 changed the title ~~Feature/fre/voice broadcast seek to~~ Voice Broadcast - Add seek bar with basic implementation Oct 31, 2022

Florian14 requested review from a team and fedrunov and removed request for a team October 31, 2022 14:30

Florian14 commented Oct 31, 2022

View reviewed changes

Base automatically changed from feature/fre/start_voice_broadcast_error to resilience-rc October 31, 2022 15:23

jmartinesp approved these changes Oct 31, 2022

View reviewed changes

Florian14 force-pushed the feature/fre/voice_broadcast_seek_to branch from d35018f to b892b79 Compare October 31, 2022 16:23

This was referenced Oct 31, 2022

Voice Broadcast - Update seek bar position while playing #7496

Merged

Voice Broadcast - Fix duplicated chunks in the internal playlist during live broadcasts #7502

Merged

jmartinesp force-pushed the resilience-rc branch from dac89ad to 7618996 Compare November 2, 2022 14:52

Florian14 force-pushed the resilience-rc branch from 7618996 to dac89ad Compare November 2, 2022 14:58

Florian Renaud added 7 commits November 2, 2022 17:06

VoiceBroadcastPlayer - Add seek control views

a851e5a

VoiceBroadcastPlayer - seek implementation

9219043

Minor cleanup

bc3fe4e

Use sum() instead of reduce operator

7d3f636

Temporary disable seekBar if playing state is paused or idle

eb61a23

Improve player transitions

b41346c

Fix line length

481388e

Florian14 force-pushed the feature/fre/voice_broadcast_seek_to branch from 9dc9796 to 481388e Compare November 2, 2022 16:07

ElementBot reviewed Nov 2, 2022

View reviewed changes

Base automatically changed from resilience-rc to develop November 2, 2022 17:19

Florian14 merged commit f34758c into develop Nov 2, 2022

Florian14 deleted the feature/fre/voice_broadcast_seek_to branch November 2, 2022 22:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voice Broadcast - Add seek bar with basic implementation #7494

Voice Broadcast - Add seek bar with basic implementation #7494

Florian14 commented Oct 31, 2022

Florian14 Oct 31, 2022

jmartinesp commented Oct 31, 2022

Florian14 commented Oct 31, 2022

jmartinesp commented Oct 31, 2022

jmartinesp left a comment

jmartinesp Oct 31, 2022

Florian14 Oct 31, 2022

Florian14 commented Oct 31, 2022

jmartinesp commented Oct 31, 2022

Florian14 commented Oct 31, 2022

ElementBot Nov 2, 2022

ElementBot Nov 2, 2022

ElementBot Nov 2, 2022

ElementBot Nov 2, 2022

sonarqubecloud bot commented Nov 2, 2022

		fastBackwardButton.isInvisible = true
		fastForwardButton.isInvisible = true

Voice Broadcast - Add seek bar with basic implementation #7494

Voice Broadcast - Add seek bar with basic implementation #7494

Conversation

Florian14 commented Oct 31, 2022

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Florian14 Oct 31, 2022

Choose a reason for hiding this comment

jmartinesp commented Oct 31, 2022

Florian14 commented Oct 31, 2022

jmartinesp commented Oct 31, 2022

jmartinesp left a comment

Choose a reason for hiding this comment

jmartinesp Oct 31, 2022

Choose a reason for hiding this comment

Florian14 Oct 31, 2022

Choose a reason for hiding this comment

Florian14 commented Oct 31, 2022

jmartinesp commented Oct 31, 2022

Florian14 commented Oct 31, 2022

ElementBot Nov 2, 2022

Choose a reason for hiding this comment

ElementBot Nov 2, 2022

Choose a reason for hiding this comment

ElementBot Nov 2, 2022

Choose a reason for hiding this comment

ElementBot Nov 2, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 2, 2022