Add setting to allow disabling direct share #7488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct share continues to be enabled by default.
As requested in #2725
Signed-off-by: Joaquín Aguirrezabalaga [email protected]
Type of change
Content
Adds a new setting under preferences "Enable direct share" that allows enabling or disabling direct share.
Direct share support was added in #2029, this PR allows the user to disable it.
Motivation and context
Closes #2725
Screenshots / GIFs
Tests
Open element
Share content from another app and check that it shows the direct share chat rooms
Open preferences in element
Check that "Enable direct share" is enabled
Disable "Enable direct share"
Restart element
Share content from another app and check that it does not show the element chat rooms in the direct share row
Open preferences in element
Disable "Enable direct share"
Restart element
Share content from another app and check that it shows the direct share chat rooms
Tested devices
Checklist