Skip to content

Add setting to allow disabling direct share #7488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

kinote
Copy link
Contributor

@kinote kinote commented Oct 30, 2022

Direct share continues to be enabled by default.

As requested in #2725

Signed-off-by: Joaquín Aguirrezabalaga [email protected]

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds a new setting under preferences "Enable direct share" that allows enabling or disabling direct share.

Direct share support was added in #2029, this PR allows the user to disable it.

Motivation and context

Closes #2725

Screenshots / GIFs

Before After
menu-no-option menu-option-on
Setting Effect
menu-option-on share-on
menu-option-off share-off

Tests

  • Open element

  • Share content from another app and check that it shows the direct share chat rooms

  • Open preferences in element

  • Check that "Enable direct share" is enabled

  • Disable "Enable direct share"

  • Restart element

  • Share content from another app and check that it does not show the element chat rooms in the direct share row

  • Open preferences in element

  • Disable "Enable direct share"

  • Restart element

  • Share content from another app and check that it shows the direct share chat rooms

Tested devices

  • Physical
  • Emulator
  • OS version(s): Physical in Android 12, emulator in lollipop API 21

Checklist

Direct share continues to be enabled by default.

As requested in element-hq#2725

Signed-off-by: Joaquín Aguirrezabalaga <[email protected]>
@bmarty bmarty self-requested a review November 7, 2022 14:38
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Nov 7, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@bmarty bmarty merged commit 537331c into element-hq:develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Disable direct share
2 participants