[Device Management] Show correct device type icons (PSG-775) #7292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
force-pushed
the
feature/mna/device-manager-type-icons
branch
from
5f6c740 to
f02b689
Compare
mnaturel
requested review from
a team and
jmartinesp
and removed request for
a team
jmartinesp
reviewed
Oct 5, 2022
| @@ -0,0 +1 @@ | |||
| [Device Management] Show correct device type icons | |||
There was a problem hiding this comment.
I have used ".wip" for all related PRs for the new device manager feature since it is under development (behind feature flag).
| @@ -30,7 +30,7 @@ import org.matrix.android.sdk.internal.util.database.RealmMigrator | |||
| * mark existing keys as safe. | |||
| * This migration can take long depending on the account | |||
| */ | |||
| internal class MigrateCryptoTo019(realm: DynamicRealm) : RealmMigrator(realm, 18) { | |||
| internal class MigrateCryptoTo019(realm: DynamicRealm) : RealmMigrator(realm, 19) { | |||
There was a problem hiding this comment.
Hopefully no. The target version is only used in RealmMigrator for log purpose.
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Display the correct device type icon on item in lists and in the session overview view.
Adding mapping from
DeviceInfoto Realm entity for the user agent field with the corresponding migration.Motivation and context
Closes #7277
Screenshots / GIFs
Tests
Tested devices
Checklist