space switcher empty spaces #6988
Conversation
fedrunov
requested review from
a team and
ganfra
and removed request for
a team
fedrunov
added
the
Z-NextRelease
fedrunov
requested review from
ericdecanini and
bmarty
and removed request for
ganfra
| @@ -71,6 +73,7 @@ class SpaceListFragment : | |||
| homeActivitySharedActionViewModel = activityViewModelProvider[HomeSharedActionViewModel::class.java] | |||
| roomListSharedActionViewModel = activityViewModelProvider[RoomListSharedActionViewModel::class.java] | |||
| views.stateView.contentView = views.groupListView | |||
| views.spacesEmptyButton.onClick { onAddSpaceSelected() } | |||
There was a problem hiding this comment.
This is maybe not new, but when the user clicks on this button, do we want to close the bottomsheet?
There was a problem hiding this comment.
@ericdecanini could you please verify?
There was a problem hiding this comment.
Ideally we don't want to close it immediately in case the user navigates back but we want to close it following a successful space creation.
There's already an issue for this #6950
Edit: This behaviour already works like this in this PR. It also may be that we can close the above mentioned issue if we investigate that this works too in other cases
| views.spacesEmptyGroup.isVisible = false | ||
| views.groupListView.isVisible = true | ||
| } | ||
| } |
There was a problem hiding this comment.
About StateView, the correct code would be:
is Success -> {
if (spaces.invoke().isEmpty()) {
views.stateView.state = StateView.State.Empty(...)
} else {
views.stateView.state = StateView.State.Content
}
}But maybe there are specific needs here? If this is the spaces_empty_button, maybe we could improve the StateView to integrate it. (can be done later, to not block this.)
There was a problem hiding this comment.
StateView has exact implementation for Empty state and I hadn't time to extend it to accept custom views (it rises some problems like callbacks for button). So in this case I had to place custom empty state near content view and switch between them. StateView her is mostly for loading state
|
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
empty state for new space switching dialog
Motivation and context
closes #6754
Screenshots / GIFs