Per room block unverified devices #6726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
requested review from
a team and
Claire1817
and removed request for
a team
Claire1817
reviewed
Aug 4, 2022
...ix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/crypto/E2eeTestConfig.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/store/IMXCryptoStore.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsController.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsAction.kt
Outdated
Show resolved
Hide resolved
BillCarsonFr
force-pushed
the
feature/bca/block_unverified
branch
2 times, most recently
from
75ae1f5 to
ec3462b
Compare
BillCarsonFr
added
the
Z-NextRelease
bmarty
approved these changes
Oct 3, 2022
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/crypto/CryptoService.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsController.kt
Outdated
Show resolved
Hide resolved
| val canUpgradeToRestricted: Boolean = false, | ||
| val encryptToVerifiedDeviceOnly: Async<Boolean> = Uninitialized, | ||
| val globalCryptoConfig: Async<GlobalCryptoConfig> = Uninitialized, | ||
| val unverifiedDevicesInTheRoom: Async<Boolean> = Uninitialized, |
There was a problem hiding this comment.
Maybe this is not necessary to use Async type for those 3 new fields. Not a blocker though.
BillCarsonFr
force-pushed
the
feature/bca/block_unverified
branch
from
e471900 to
e92a047
Compare
bmarty
approved these changes
Oct 4, 2022
| // } | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
All the commented out block could be removed.
Co-authored-by: Benoit Marty <[email protected]>
BillCarsonFr
force-pushed
the
feature/bca/block_unverified
branch
from
680e0f4 to
b567fc5
Compare
ElementBot
reviewed
Oct 5, 2022
| @@ -7,6 +7,8 @@ | |||
| android:background="?android:colorBackground" | |||
There was a problem hiding this comment.
⚠️ Possible overdraw: Root element paints background?android:colorBackgroundwith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)⚠️ Possible overdraw: Root element paints background?android:colorBackgroundwith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)
| @@ -7,6 +7,8 @@ | |||
| android:background="?android:colorBackground" | |||
| android:foreground="?attr/selectableItemBackground" | |||
There was a problem hiding this comment.
⚠️ Attributeandroid:foregroundhas no effect on API levels lower than 23 (current min is 21)⚠️ Attributeandroid:foregroundhas no effect on API levels lower than 23 (current min is 21)
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Fixes #6725
Content
Adds the option to only send keys to verified devices per room. The setting was ready in SDK but just not exposed in UI.
Also added UI feedback when the option is on in global settings.
Motivation and context
Screenshots / GIFs
Tested devices
Checklist