filtered room list at home #6724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedrunov
requested review from
a team and
yostyle
and removed request for
a team
added 2 commits
August 3, 2022 13:32
# Conflicts: # vector/src/main/java/im/vector/app/features/home/HomeDetailFragment.kt # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListAction.kt # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomSection.kt
amshakal
approved these changes
Aug 8, 2022
ericdecanini
suggested changes
Aug 9, 2022
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
|
|
||
| <style name="Widget.App.TabLayout" parent="Widget.MaterialComponents.TabLayout"> |
There was a problem hiding this comment.
Let's do Widget.Vector.TabLayout for consistent with other styles in the app
|
|
||
| class HomeRoomListViewModel @AssistedInject constructor( | ||
| @Assisted initialState: HomeRoomListViewState, | ||
| private val session: Session, | ||
| private val spaceStateHandler: SpaceStateHandler, | ||
| private val vectorPreferences: VectorPreferences, | ||
| private val spaceStateHandler: SpaceStateHandler |
There was a problem hiding this comment.
Can we add a trailing comma here?
There was a problem hiding this comment.
Suggested change
| private val spaceStateHandler: SpaceStateHandler | |
| private val spaceStateHandler: SpaceStateHandler, |
# Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListViewModel.kt
yostyle
approved these changes
Aug 10, 2022
|
|
||
| class HomeRoomListViewModel @AssistedInject constructor( | ||
| @Assisted initialState: HomeRoomListViewState, | ||
| private val session: Session, | ||
| private val spaceStateHandler: SpaceStateHandler, | ||
| private val vectorPreferences: VectorPreferences, | ||
| private val spaceStateHandler: SpaceStateHandler |
There was a problem hiding this comment.
Suggested change
| private val spaceStateHandler: SpaceStateHandler | |
| private val spaceStateHandler: SpaceStateHandler, |
ericdecanini
suggested changes
Aug 11, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
part of #6502
closes #6505
Screenshots / GIFs