Skip to content

[Location sharing] - OnTap on the top live status bar, display the expanded map view (PSG-614) #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2022
Merged

[Location sharing] - OnTap on the top live status bar, display the expanded map view (PSG-614) #6626

merged 3 commits into from
Jul 25, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UX improvement

Content

Navigating to expanded map view when tapping on the status bar which indicates a live is active.

Motivation and context

Closes #6625

Screenshots / GIFs

Tests

  • Go to a room
  • Start a live location share
  • Press on the top status bar
  • Check it navigates to the expanded map view
  • Go back to timeline
  • Press the stop button on the top status bar
  • Check the live is ended

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label Jul 22, 2022
@mnaturel mnaturel marked this pull request as ready for review July 22, 2022 12:38
@mnaturel mnaturel requested review from a team and bmarty and removed request for a team July 22, 2022 12:38
bmarty
bmarty approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark, else LGTM.

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt Outdated
@@ -859,6 +859,9 @@ class TimelineFragment @Inject constructor(
views.locationLiveStatusIndicator.stopButton.debouncedClicks {
timelineViewModel.handle(RoomDetailAction.StopLiveLocationSharing)
}
views.locationLiveStatusIndicator.root.debouncedClicks {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but is it mandatory to use root?

I was wondering if views.locationLiveStatusIndicator.debouncedClicks { would work the same way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, the root is not needed, I removed it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit c3bc53f into develop Jul 25, 2022
@mnaturel mnaturel deleted the feature/mna/open-map-on-tap-of-lls-status-bar branch July 25, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Location sharing] - OnTap on the top live status bar, display the expanded map view
2 participants
@mnaturel @bmarty