-
Notifications
You must be signed in to change notification settings - Fork 782
Making bug report screenshots opt in instead of opt out #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making bug report screenshots opt in instead of opt out #6297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some thoughts that you may already have considered yourself.
@@ -154,7 +154,7 @@ | |||
android:layout_height="wrap_content" | |||
android:layout_marginStart="10dp" | |||
android:layout_marginEnd="10dp" | |||
android:checked="true" | |||
android:checked="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This toggle also affects the visibility of the screenshot on this screen (bug_report_screenshot_preview
).
Maybe hide the screenshot by default, or make it always visible? But maybe stay like that, so the user can see the screenshot that will be sent if they check the box, and when they check and uncheck, the screenshot will be GONE.
Also, if the checkbox is not checked, and the user sends the report, maybe add a dialog like "Do you want to include a screenshot to your report?". I am afraid that we will get less screenshots with this change, even if generally there are quite useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for making the screenshot preview always visible d881497
for the UX change this feels like something that would need product input, most bug reports which include screenshots often don't contain the reported bug (eg crashes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
Makes screenshots opt-in rather than opt-out as screenshots contain messages which the logs do not
Motivation and context
Fixes #6261
Screenshots / GIFs
Tests
Tested devices