Skip to content

Making bug report screenshots opt in instead of opt out #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Bug report defaults

Content

Makes screenshots opt-in rather than opt-out as screenshots contain messages which the logs do not

Motivation and context

Fixes #6261

Screenshots / GIFs

Before After
Screenshot_20220613_180354 Screenshot_20220613_181111

Tests

  • Open a bug report
  • Notice the send screenshot toggle is disabled

Tested devices

  • Physical
  • Emulator
  • OS version(s): 28

@ouchadam ouchadam added the PR-Small PR with less than 20 updated lines label Jun 13, 2022
@ouchadam ouchadam requested review from a team, yostyle and bmarty and removed request for a team June 13, 2022 17:17
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some thoughts that you may already have considered yourself.

@@ -154,7 +154,7 @@
android:layout_height="wrap_content"
android:layout_marginStart="10dp"
android:layout_marginEnd="10dp"
android:checked="true"
android:checked="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This toggle also affects the visibility of the screenshot on this screen (bug_report_screenshot_preview).
Maybe hide the screenshot by default, or make it always visible? But maybe stay like that, so the user can see the screenshot that will be sent if they check the box, and when they check and uncheck, the screenshot will be GONE.
Also, if the checkbox is not checked, and the user sends the report, maybe add a dialog like "Do you want to include a screenshot to your report?". I am afraid that we will get less screenshots with this change, even if generally there are quite useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for making the screenshot preview always visible d881497

for the UX change this feels like something that would need product input, most bug reports which include screenshots often don't contain the reported bug (eg crashes)

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ouchadam ouchadam enabled auto-merge June 16, 2022 10:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ouchadam ouchadam merged commit 4f86ad0 into develop Jun 16, 2022
@ouchadam ouchadam deleted the feature/adm/opt-in-screenshots-in-bug-report branch June 16, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rageshake submission dialog should default screenshots to off
3 participants