Allow sharing text mimetype content via android's share menu #6296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
requested review from
a team,
Claire1817 and
fedrunov
and removed request for
a team
ouchadam
commented
Jun 13, 2022
| @@ -214,7 +214,7 @@ class AttachmentsHelper(val context: Context, val callback: Callback) : Restorab | |||
| it.toContentAttachmentData() | |||
| } | |||
| ) | |||
| } else if (type.startsWith("application") || type.startsWith("file") || type.startsWith("*")) { | |||
| } else if (type.startsWith("application") || type.startsWith("file") || type.startsWith("text") || type.startsWith("*")) { | |||
There was a problem hiding this comment.
do we want to explicitly handle all the possible cases? or should our else case allow handling any type as a file?
There was a problem hiding this comment.
For me i prefer to explicitly handle all the possible cases to keep the control of what we send. It's easy to add a new type if a user need it.
|
Kudos, SonarCloud Quality Gate passed! |
Claire1817
approved these changes
Jun 14, 2022
| @@ -214,7 +214,7 @@ class AttachmentsHelper(val context: Context, val callback: Callback) : Restorab | |||
| it.toContentAttachmentData() | |||
| } | |||
| ) | |||
| } else if (type.startsWith("application") || type.startsWith("file") || type.startsWith("*")) { | |||
| } else if (type.startsWith("application") || type.startsWith("file") || type.startsWith("text") || type.startsWith("*")) { | |||
There was a problem hiding this comment.
For me i prefer to explicitly handle all the possible cases to keep the control of what we send. It's easy to add a new type if a user need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Allows
text/*content types to be shared via android share menu as file attachments.Motivation and context
Fixes #6285
Screenshots / GIFs
Tests
Tested devices