Feature/bma/fix typing #6072
Feature/bma/fix typing #6072
Conversation
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| app:barrierDirection="top" | ||
| app:constraint_referenced_ids="composerLayout,notificationAreaView,failedMessagesWarningStub" /> |
There was a problem hiding this comment.
this was duplicated code with badgeBarrier which has been renamed to bottomBarrier
bmarty
added
the
Z-NextRelease
bmarty
requested review from
a team,
ouchadam and
fedrunov
and removed request for
a team
| android:paddingStart="20dp" | ||
| android:paddingEnd="20dp" | ||
| app:layout_constraintBottom_toTopOf="@id/composerLayout" | ||
| app:layout_constraintBottom_toTopOf="@id/bottomBarrier" |
There was a problem hiding this comment.
This view is now on top of the barrier, and the timeline is now on top of this view.
| const val OVERLAP_FACT0R = -3 // =~ 30% to left | ||
| } | ||
|
|
||
| private val typingAvatarSize by lazy { |
There was a problem hiding this comment.
if render is always called from the main thread we could use the unsafe lazy initializer to avoid a synchronised call
|
|
||
| <!-- This is a LinearLayout which will contain avatars of the typing users --> |
There was a problem hiding this comment.
this comment feels like it could be replaced by renaming the id to typingUsersAvatars
There was a problem hiding this comment.
(I keep the comment since I added it for clarity when looking at the layout. Since there is no avatar preview)
|
is it intentional for the typing indicator to no longer overlap the content but instead provide its own background? (to double check if this was missing from the original implementation or intended from a design perspective) |
For the original design, there is a Figma link in #3296. I think the design wanted the typing notification not to be visible when the timeline is scrolled. But implementing that is out of scope of this PR. |
probably worth a ticket so we don't forget to revisit 🤞 |
Matrix SDKIntegration Tests Results:
|
Type of change
Content
Motivation and context
Fixes #6063
Also fixes #5632
Screenshots / GIFs
Tests
Tested devices
Checklist