Replaces monarchy.doWithRealm with monarchy.awaitTransaction #5792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
reviewed
Apr 20, 2022
| @@ -93,7 +93,7 @@ internal class SyncResponsePostTreatmentAggregatorHandler @Inject constructor( | |||
|
|
|||
| private fun List<User>.saveLocally() { | |||
| val userEntities = map { user -> UserEntityFactory.create(user) } | |||
| monarchy.doWithRealm { | |||
| monarchy.writeAsync { | |||
There was a problem hiding this comment.
should this be awaitTransaction to force the suspend flow to be synchronous?
I'm wondering if logic further down the flow is expecting these database values to be set
There was a problem hiding this comment.
We should have completed this before the next sync yeah
There was a problem hiding this comment.
(even if technically we can only have one transaction at a time)
ouchadam
approved these changes
Apr 20, 2022
ericdecanini
changed the title
ouchadam
added
the
Z-NextRelease
ganfra
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Replaces monarchy.doWithRealm with monarchy.awaitTransaction
Motivation and context
This fixes a bug that was crashing the whole sync
Screenshots / GIFs
Tests
Test that #5618 still works and no errors are thrown as a result of the sync
Tested devices
Checklist