Add a setting to be able to always appear offline #5583

aringenbach · 2022-03-18T16:21:44Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Presence enabling has been moved to an offline mode user setting. When enabled, user will always appear offline, even when using the application.

Motivation and context

Fixes #5582

Screenshots / GIFs

Tests

Step 1: Have contacts on servers that show presence (e.g. local synapse)
Step 2: Toggle setting

Tested devices

Physical
Emulator
OS version(s): API 32

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

aringenbach

This might require input from product team, as this is adding a setting we might not want for some reason.

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt

github-actions · 2022-03-18T17:06:41Z

Unit Test Results

114 files ±0 114 suites ±0 1m 18s ⏱️ -6s
201 tests ±0 201 ✔️ ±0 0 💤 ±0 0 ❌ ±0
674 runs ±0 674 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5cd559a. ± Comparison against base commit 836a12d.

♻️ This comment has been updated with latest results.

ariskotsomitopoulos

Thanks for the PR, I added some comments

...id/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/PresenceSyncHandler.kt

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt

vector/src/main/res/xml/vector_settings_preferences.xml

aringenbach · 2022-03-21T15:12:04Z

This might require input from product team, as this is adding a setting we might not want for some reason.

Done. It's ok to have this setting available, and it will be added on iOS as well as part of the presence display improvement there.

ariskotsomitopoulos

It would be good to avoid the activity restart if possible. I added a comment regarding that

…tting # Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/MatrixConfiguration.kt # vector/src/main/java/im/vector/app/core/di/SingletonModule.kt # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

…tting

vector-config/src/main/res/values/config-settings.xml

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt

ariskotsomitopoulos

Thanks for the update, some comments

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt

vector-config/src/main/res/values/config-settings.xml

bmarty

Some minor and less minor remarks

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/MatrixConfiguration.kt

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt

vector/src/main/res/values/strings.xml

…tting # Conflicts: # vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt

…tting # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

bmarty

Thanks for the update.

Just a last remark about the changelog.

Also the PR description is quite out of date. Can you update it please, for posterity?

bmarty · 2022-04-12T07:51:56Z

...main/java/org/matrix/android/sdk/internal/session/presence/service/DefaultPresenceService.kt

 ) : PresenceService {

    override suspend fun setMyPresence(presence: PresenceEnum, statusMsg: String?) {
+        lightweightSettingsStorage.setSyncPresenceStatus(SyncPresence.from(presence))


Not a big deal, but storing the value could be handled by setPresenceTask. Not sure what is best, so let's keep it like that.

changelog.d/5582.change

…tting

bmarty

Thanks, for the update. I will squash and commit.

Move presence enabling to a app-only preference

bfc19f8

aringenbach commented Mar 18, 2022

View reviewed changes

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt Outdated Show resolved Hide resolved

Remove enable presence sync build config

07cb57a

aringenbach requested review from a team and ariskotsomitopoulos and removed request for a team March 18, 2022 16:57

ariskotsomitopoulos reviewed Mar 21, 2022

View reviewed changes

Use config defined default value for switch

5087a97

aringenbach requested a review from ariskotsomitopoulos March 21, 2022 15:12

ariskotsomitopoulos approved these changes Mar 21, 2022

View reviewed changes

aringenbach added 7 commits March 23, 2022 09:48

Update to a presence offline mode

382bb34

Merge branch 'develop' into feature/aringenbach/presence-sync-user-se…

26c7ec6

…tting

Cleanup and update changelog

49d4238

Hide presence settings by default

ecd0472

Fix lint issue

bbf0d7f

Fix lint issues

e04d1e9

aringenbach changed the title ~~Move presence enabling to a app-only preference~~ Move presence enabling to a offline mode user setting Mar 30, 2022

aringenbach changed the title ~~Move presence enabling to a offline mode user setting~~ Move presence enabling to an offline mode user setting Mar 30, 2022

aringenbach added 5 commits March 30, 2022 09:36

Fix changelog typo

23ca2cf

Remove unnecessary brackets

41bdd3c

Remove unused import

1c5008b

Add offline mode preference description

90e6eb4

Bind setting directly to SDK SharedPref

6276a82

aringenbach commented Mar 30, 2022

View reviewed changes

vector-config/src/main/res/values/config-settings.xml Outdated Show resolved Hide resolved

aringenbach requested a review from ariskotsomitopoulos March 30, 2022 08:44

Remove useless inject

3c0b43f

aringenbach commented Mar 31, 2022

View reviewed changes

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt Show resolved Hide resolved

ariskotsomitopoulos reviewed Mar 31, 2022

View reviewed changes

bmarty requested changes Mar 31, 2022

View reviewed changes

aringenbach added 3 commits March 31, 2022 16:54

Rework app & SDK presence shared prefs

0a8b16e

Remove unused inject

7cb9619

Fix line length

ee6bab2

aringenbach requested a review from bmarty March 31, 2022 17:40

aringenbach added 3 commits April 4, 2022 17:06

Merge branch 'develop' into feature/aringenbach/presence-sync-user-se…

e286110

…tting # Conflicts: # vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt

Fix return spacing

3197908

Merge branch 'develop' into feature/aringenbach/presence-sync-user-se…

7658ae6

…tting # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

bmarty requested changes Apr 12, 2022

View reviewed changes

aringenbach added 2 commits April 12, 2022 10:07

Merge branch 'develop' into feature/aringenbach/presence-sync-user-se…

bc6b0f1

…tting

Update changelog

5cd559a

aringenbach changed the title ~~Move presence enabling to an offline mode user setting~~ Add a setting to be able to always appear offline Apr 12, 2022

aringenbach requested a review from bmarty April 12, 2022 09:08

bmarty approved these changes Apr 12, 2022

View reviewed changes

bmarty merged commit 047a45d into develop Apr 12, 2022

bmarty deleted the feature/aringenbach/presence-sync-user-setting branch April 12, 2022 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a setting to be able to always appear offline #5583

Add a setting to be able to always appear offline #5583

aringenbach commented Mar 18, 2022 •

edited

Loading

aringenbach left a comment

github-actions bot commented Mar 18, 2022 •

edited

Loading

ariskotsomitopoulos left a comment

aringenbach commented Mar 21, 2022

ariskotsomitopoulos left a comment

ariskotsomitopoulos left a comment

bmarty left a comment

bmarty left a comment

bmarty Apr 12, 2022

bmarty left a comment

Add a setting to be able to always appear offline #5583

Add a setting to be able to always appear offline #5583

Conversation

aringenbach commented Mar 18, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

aringenbach left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 18, 2022 • edited Loading

Unit Test Results

ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

aringenbach commented Mar 21, 2022

ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty Apr 12, 2022

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

aringenbach commented Mar 18, 2022 •

edited

Loading

github-actions bot commented Mar 18, 2022 •

edited

Loading