Read receipt in wrong order

[Claire1817]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Update read receipt order in the factory.

Motivation and context

#5514

Screenshots / GIFs

Tests

Open ready receipt details on a message (especially if there is some events hidden before it)

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

  98 files  ±  0    98 suites  ±0   1m 9s ⏱️ -5s
178 tests +  4  178 ✔️ +  4  0 💤 ±0  0 ❌ ±0 
584 runs  +16  584 ✔️ +16  0 💤 ±0  0 ❌ ±0 

Results for commit 6c7b4d4. ± Comparison against base commit acfeb7f.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling display name update then updates upstream user display name

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is not supported when updating display name then updates upstream user display name and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is supported when updating display name then updates upstream user display name and moves to choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given homeserver does not support personalisation when registering account then updates state and emits account created event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given only supports changing profile picture when handling PersonalizeProfile then emits contents choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given supports changing display name when handling PersonalizeProfile then emits contents choose display name

♻️ This comment has been updated with latest results.

[ouchadam]

do we know why this extra sorting is needed? it looks like we're already sorting by originServerTs https://github.com./vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/mapper/TimelineEventMapper.kt#L53 (assuming this mapper is used)

[Claire1817]

it's necessary when we have to concatenate the read receipts which come from different events (not displayed by default in android application but displayed in web application). The complete list is not ordered but each small list is.

[ouchadam]

👍 thanks for the explanation

[ouchadam]

we can avoid the extra function by applying the sorting here

.map { ... }
.sortedByDescending { it.timestamp }

also looks like the toList isn't needed

[Claire1817]

yes, you're right :)

[ouchadam]

💯 thanks!

[bmarty]

The fix is OK, but I think the sorting should be rather done SDK side.