Call transfer with consult fails to make outgoing consultation call. #5203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on intent then onNewIntent called.
Matrix SDKIntegration Tests Results:
|
ouchadam
reviewed
Feb 11, 2022
vector/src/main/java/im/vector/app/features/call/transfer/CallTransferViewModel.kt
Show resolved
Hide resolved
ouchadam
reviewed
Feb 11, 2022
vector/src/main/java/im/vector/app/features/call/transfer/CallTransferActivity.kt
Outdated
Show resolved
Hide resolved
ouchadam
reviewed
Feb 11, 2022
vector/src/main/java/im/vector/app/features/call/transfer/CallTransferActivity.kt
Show resolved
Hide resolved
ouchadam
approved these changes
Feb 11, 2022
bmarty
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5201
First part of fix
Intent information(
EXTRA_MODE) that is pass to attachViewRenderers here is not present on intent whenonNewIntentis called, so the outgoing call is never placed. Fix is to set the intent here.Second part of fix
A follow on issue was related to a recent PR that puts other caller on hold when going to the transfer selection and off hold when they cancel.
With consult transfers, As the consult call is started in a new task, the call transfer selection activity immediately gets returned with
RESULT_CANCELLED(rather thanRESULT_OKfrom theCompleteview action in turn callingsetResult). This means we do an additional unintended unhold and this places the new call in the incorrect hold state.2 options for a solution
The second option seemed pretty reasonable to me and we actually already do the second part of the consult transfer from the call view model already. So went with that.