Skip to content

spaces restricted promo removed #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2022
Merged

spaces restricted promo removed #5131

merged 1 commit into from
Feb 2, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Feb 2, 2022

fixes #4315

bmarty
bmarty approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unit Test Results

  76 files  ±0    76 suites  ±0   54s ⏱️ -10s
143 tests ±0  143 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
448 runs  ±0  448 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 440c5f7. ± Comparison against base commit 65fd548.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@bmarty bmarty merged commit 6ebba4e into develop Feb 2, 2022
@bmarty bmarty deleted the feature/nfe/spaces_promo_removal branch February 2, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spaces: "New: Let people in spaces find and join private room" doesn't seem relevant
2 participants
@fedrunov @bmarty