Edit Polls and Allow Undisclosed Polls #5020
Conversation
Matrix SDKIntegration Tests Results:
|
* develop: (66 commits) toolbar management (#4887) adding changelog entry adding back periodic flag when scheduling automatic background workers Fix enum class warning Split long lines Done by matrix-org/matrix-analytics-events#16 Add new class in analytics plan Fix conditional for Delight issue automation Add missing import in kdoc Update kdoc Enable Delight issue automation Fix an error in string resource (#4997) Changelog Add some unit test for the command parser. Not all commands are covered, could add more tests later. data class. use sealed interface Small cleanup Command parser is not a static object anymore Add changelog Use Throwable.isLimitExceededError extension Do not automatically retry 429 with a too long delay ...
| data class PollUndisclosed(override val optionId: String, | ||
| override val optionAnswer: String, | ||
| val isSelected: Boolean | ||
| ) : PollOptionViewState(optionId, optionAnswer) |
There was a problem hiding this comment.
Happy to see that the arch here is nice to do such addition of a new state!
| @@ -51,4 +51,12 @@ sealed class PollOptionViewState(open val optionId: String, | |||
| val votePercentage: Double, | |||
| val isWinner: Boolean | |||
| ) : PollOptionViewState(optionId, optionAnswer) | |||
|
|
|||
| /** | |||
| * Represent a poll that is closed, votes will be hidden until the poll is ended. | |||
There was a problem hiding this comment.
Maybe replace closed by undisclosed to avoid confusion between close and ended
| _viewEvents.post(CreatePollViewEvents.Success) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun sendEditedPoll(editedEventId: String, pollType: PollType, question: String, options: List<String>) { | ||
| val editedEvent = room.getTimeLineEvent(editedEventId) ?: return | ||
| room.editPoll(editedEvent, pollType, question, options) |
There was a problem hiding this comment.
Nit: room.editPoll() first parameter could be an eventId: String to let the SDK user have a nicer API.
There was a problem hiding this comment.
But we don't have the room instance in EventEditor. Do we really want to inject session and pass the roomId and eventId?
There was a problem hiding this comment.
OK, the API is similar to the other ones, you can leave it like this, sorry.
| @@ -53,14 +53,8 @@ | |||
|
|
|||
| <im.vector.app.core.preference.VectorSwitchPreference | |||
| android:defaultValue="false" | |||
| android:key="SETTINGS_LABS_ENABLE_POLLS" | |||
| android:title="@string/labs_enable_polls" /> | |||
There was a problem hiding this comment.
Can you add a comment above the string resource labs_enable_polls like <!-- TODO Remove --> please?
There was a problem hiding this comment.
Done, I was thinking to ask you about this.
|
Quick smoke test, everything worked fine. |
Fixes: #5036, Fixes #5037
Figma