Skip to content

Fix unread marker not showing #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix unread marker not showing #4316

merged 1 commit into from
Oct 22, 2021

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 22, 2021

Fix #4313

bmarty
bmarty approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
Looks like you have checked all the usages of tryEmit. Do you confirm?

vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewModel.kt
timelineEvents.tryEmit(snapshot)

viewModelScope.launch {
// tryEmit doesn't work with SharedFlow without cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the fix. How can we avoid such error to come back in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the DataSource abstraction we have? (not yet migrated to Flow)

@bmarty bmarty merged commit 09fbd5f into develop Oct 22, 2021
@bmarty bmarty deleted the feature/fga/fix_4313 branch October 22, 2021 13:42
@github-actions
Copy link

Unit Test Results

  48 files  ±0    48 suites  ±0   53s ⏱️ +8s
  91 tests ±0    91 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
244 runs  ±0  244 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a82a5c9. ± Comparison against base commit 0d1382a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unread marker not showing since 1.3.4
2 participants
@ganfra @bmarty