Fixing notifications not being dismissed when read from other devices #4129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aining the event is no longer the latest - use explict returns constants to attempt to add more documentation - queries for the existence of the event in all of the chunk history and if a read receipt exists in the latest chunk (which it should if a user has just read on another client) which allows us to mark old notifications events as read
bmarty
approved these changes
Oct 1, 2021
| @@ -23,6 +23,9 @@ import org.matrix.android.sdk.internal.database.model.TimelineEventEntity | |||
| import io.realm.Realm | |||
| import io.realm.RealmConfiguration | |||
|
|
|||
| private const val MARK_OLD_EVENT_AS_READ = true | |||
| private const val MARK_UNREAD_DUE_TO_FASTLANE = false | |||
There was a problem hiding this comment.
I'm not sure declaring const for boolean returned value increases the readability of the code. Maybe a good comment is better?
There was a problem hiding this comment.
👍 I think this is a sign that the handleMissingEvent is the wrong name, renaming to hasReadMissingEvent allows us to infer the return result is has read or has not read
| } | ||
|
|
||
| private fun Realm.hasReadReceiptInLatestChunk(latestChunkEntity: ChunkEntity, roomId: String, userId: String) : Boolean { | ||
| return ReadReceiptEntity.where(this, roomId, userId).findFirst()?.let { |
There was a problem hiding this comment.
Nit: The code is OK, but maybe use named arguments for roomId and userId to avoid confusion, since the types are the same (String)
ouchadam
force-pushed
the
feature/adm/sync-read-notifications
branch
from
4a51583 to
c72f668
Compare
bmarty
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3347 and #523
Our notification dismissing works by matching the currently held notification events to the latest timeline chunk for the room, this presents a problem when the next chunk is created which doesn't reference those original notification events, which then presents itself as notifications not being dismissed when read from other sessions.
The fix is to check the existence of missing events against the entire chunk history if there's also a read receipt event in the latest chunk.
Here's the worlds least exciting gif... notice the element icon in the top