Skip to content

QR code view broken when no display name is set #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kittykat opened this issue Mar 4, 2022 · 3 comments
Closed

QR code view broken when no display name is set #5424

kittykat opened this issue Mar 4, 2022 · 3 comments
Labels
A-Invite help wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF moment: High Impact, Low Effort

Comments

@kittykat
Copy link
Contributor

kittykat commented Mar 4, 2022 •
edited
Loading

Steps to reproduce

  1. Unset your display name (in Settings -> General)
  2. Left panel -> miniature QR code next to your name

Outcome

What did you expect?

Avatar does not cover MXID
Screenshot_20220304-131348.png

What happened instead?

Avatar covers MXID
Screenshot_20220304-132618.png

Your phone model

iPhone 11

Operating system version

Android 11

Application version and app store

Playstore Beta
@kittykat kittykat added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 4, 2022
@ouchadam ouchadam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-WTF WTF moment: High Impact, Low Effort A-Invite labels Mar 22, 2022
@ouchadam
Copy link
Contributor

Marked as uncommon due to needing to have no display name set, however I'm tempted to increase the severity as the invitation flow is a pretty important to us, might also fall under FTUE? cc @daniellekirkwood

@daniellekirkwood
Copy link
Contributor

Thanks @ouchadam

I'm going to upgrade this to Major as it's a visual defect and severely impacts the user experience in D1 (for both the sharer of the code and the scanner). That makes it a P3 issue but maybe it's small enough that could be fixed very quickly...

@kittykat kittykat added the help wanted Extra attention is needed label Aug 31, 2022
pt2121 added a commit to pt2121/element-android that referenced this issue Sep 10, 2022
@pt2121
Fix add by QR code layout (element-hq#5424)
6752a2a
pt2121 added a commit to pt2121/element-android that referenced this issue Sep 10, 2022
@pt2121
Fix add by QR code layout (element-hq#5424)
2cf408f
pt2121 added a commit to pt2121/element-android that referenced this issue Sep 10, 2022
@pt2121
Fix add by QR code layout (element-hq#5424)
73eb63a 
Signed-off-by: Prat T <[email protected]>
@pt2121 pt2121 mentioned this issue Sep 10, 2022
Merged
15 tasks
bmarty added a commit that referenced this issue Sep 12, 2022
@bmarty
Merge pull request #7092 from pt2121/pt/5424-qr
7f766ee 
Fix add by QR code layout (#5424)
@bmarty
Copy link
Member

bmarty commented Sep 12, 2022

Fixed in #7092 (Element Android 1.4.38)

@bmarty bmarty closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Invite help wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @ouchadam @bmarty @daniellekirkwood