impl framework data_source.fleet_enrollment_tokens #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daemitus
commented
Sep 18, 2024
daemitus
commented
- Migrated the fleet enrollment_tokens data_source to the plugin framework.
- removed resource.isReady from several places, added the same check to ConvertProviderData. The error will propagate up when resource.Configure is called, no need to keep it in the CRUD methods.
- converted the enrollment_token fleet APIs to return fwdiags.
tobio
reviewed
Sep 19, 2024
daemitus
commented
Sep 19, 2024
|
|
||
| // SliceToListType converts a tfsdk naive []T1 into an types.List of []T2. | ||
| // This handles both structs and simple types to attr.Values. | ||
| func SliceToListType[T1 any, T2 any](ctx context.Context, value []T1, elemType attr.Type, path path.Path, diags diag.Diagnostics, iteratee func(item T1) T2) types.List { |
There was a problem hiding this comment.
What is your hot take on helpers like this? While its not much of a problem in this data_source, I've had a ton of issues with naive slices as compared to types.List members. In the more complicated nested structs, these let you just inline a lot of boilerplate.
There was a problem hiding this comment.
👍 I think there's likely a lot of room for more helpers like this in this codebase.
tobio
approved these changes
Sep 19, 2024
tobio
added a commit
that referenced
this pull request
Sep 30, 2024
* origin/main: (39 commits) chore(deps): update golang:1.23.1 docker digest to 4f063a2 (#804) fix(deps): update module github.com./go-resty/resty/v2 to v2.15.3 (#781) fix for http/tcp monitor produces inconsistent result after apply (#801) chore(deps): update docker.elastic.co/elasticsearch/elasticsearch docker tag to v8.15.2 (#798) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v8.15.2 (#799) Bump github.com./oapi-codegen/oapi-codegen/v2 in /tools (#808) Bump github.com./oapi-codegen/oapi-codegen/v2 from 2.4.0 to 2.4.1 (#806) Bump actions/checkout from 4.1.7 to 4.2.0 (#807) more fleet framework migrations (#785) Apply the sys_monitoring attribute during creation (#792) fix(deps): update module github.com./oapi-codegen/oapi-codegen/v2 to v2.4.0 (#788) fix(docs): indices datesource example field (#786) fix(deps): update module github.com./hashicorp/terraform-plugin-framework to v1.12.0 (#782) chore(deps): pin golang docker tag to 2fe82a3 (#783) Remove GO_VERSION indirection Fix release pipeline Prepare release v0.11.7 fix(deps): update module github.com./goreleaser/goreleaser/v2 to v2.3.2 (#776) impl framework data_source.fleet_enrollment_tokens (#778) Add support for the `alerts_filter` param in the Create Rule API (#774) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.