Skip to content

feat(synthetics): support for private location resource #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 6, 2024
Merged

feat(synthetics): support for private location resource #696

merged 17 commits into from
Aug 6, 2024

Conversation

biscout42
Copy link
Contributor

@biscout42 biscout42 commented Aug 2, 2024 •
edited
Loading

Part of #610

TODOs:

  • Get feedback about private location (PL) schema
  • Add unit tests for PL schema
  • Handle PL NotFound
  • Documentation of PL

tobio
tobio reviewed Aug 5, 2024
View reviewed changes
@biscout42 biscout42 marked this pull request as ready for review August 5, 2024 15:47
@biscout42 biscout42 requested a review from tobio August 5, 2024 15:47
@biscout42 biscout42 enabled auto-merge (squash) August 5, 2024 16:04
tobio
tobio reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are you able to add an entry to CHANGELOG.md for this one and add the doc template/examples.

🎉

@biscout42 biscout42 requested a review from tobio August 6, 2024 08:07
tobio
tobio approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small changes.

templates/resources/kibana_synthetics_private_location.tmpl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be named kibana_synthetics_private_location.md.tmpl. TBH I think I've done this exact thing for 9/10 new resources.

@biscout42 biscout42 merged commit f417c7c into elastic:main Aug 6, 2024
19 checks passed
@tobio
Copy link
Member

tobio commented Aug 6, 2024

Sorry @biscout42, I forgot to check if auto-merge was on. Are you able to fix the template filename in a follow-up?

@biscout42
Copy link
Contributor Author

@tobio , sorry, will do.

biscout42 added a commit to biscout42/terraform-provider-elasticstack that referenced this pull request Aug 6, 2024
@biscout42
chore: follow-up CR changes for synthetics private location resource
a44b32b 
 related to elastic#696
@biscout42 biscout42 mentioned this pull request Aug 6, 2024
Merged
@biscout42 biscout42 deleted the kibana-synthetics-monitor-resource branch August 6, 2024 09:56
biscout42 added a commit that referenced this pull request Aug 6, 2024
@biscout42
chore: follow-up CR changes for synthetics private location resource (#…
962fbb8 
…697)

related to #696
@tobio tobio mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biscout42 @tobio