Skip to content

Fix setting ID for Fleet outputs and servers #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GeorgeGkinis
Copy link
Contributor

Currently the output_id setting is ignored in elasticstack_fleet_output as does the host_id for the elasticstack_fleet_server_host resource

This is getting fixed with this pull request.

@GeorgeGkinis
Copy link
Contributor Author

@tobio
Just a heads-up that this PR is created.

I have not filled an issue. Is that needed before a PR is merged?

@GeorgeGkinis GeorgeGkinis marked this pull request as draft June 16, 2024 09:13
@GeorgeGkinis GeorgeGkinis marked this pull request as ready for review June 16, 2024 09:19
tobio
tobio previously approved these changes Jun 16, 2024
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you add an entry to CHANGELOG.md for this one?

@GeorgeGkinis
Copy link
Contributor Author

@tobio done.

@tobio tobio merged commit eb077fd into elastic:main Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants