Sort Fleet integration policy inputs to ensure consistency #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When new inputs are read from the Fleet API, the list is sorted according to the existing plan. Any new inputs added from the API will be moved to the end of the list. This ensures a consistency of inputs and prevents unnecssary changes from appearing.
tobio
previously approved these changes
Nov 29, 2023
I was thinking the same thing. I originally thought of doing a full acceptance test, but it would be tricky to get that right, and more importantly, keep it right over time. I'll go ahead and write up a unit test. |
tobio
approved these changes
Nov 29, 2023
daemitus
pushed a commit
to daemitus/terraform-provider-elasticstack
that referenced
this pull request
Nov 30, 2023
* Sort Fleet integration policy inputs to ensure consistency - When new inputs are read from the Fleet API, the list is sorted according to the existing plan. Any new inputs added from the API will be moved to the end of the list. This ensures a consistency of inputs and prevents unnecssary changes from appearing. * Changelog * Extract sort function and add unit test
daemitus
pushed a commit
to daemitus/terraform-provider-elasticstack
that referenced
this pull request
Nov 30, 2023
* Sort Fleet integration policy inputs to ensure consistency - When new inputs are read from the Fleet API, the list is sorted according to the existing plan. Any new inputs added from the API will be moved to the end of the list. This ensures a consistency of inputs and prevents unnecssary changes from appearing. * Changelog * Extract sort function and add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473