Skip to content

Update fleet output resource to new API schema format #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

Update fleet output resource to new API schema format #434

merged 1 commit into from
Oct 3, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Sep 27, 2023 •
edited
Loading

  • Updated fleet output to use new schema format, where each output kind now has a strongly typed data structure to hold the relevant configuration items.
  • Relocated the fleet api generators to match repo style, and cleaned up the schema downloader and filtering functions.
  • Expose 'ca_trusted_fingerprint' config value
  • Add test case for logstash output
  • Update Fleet API version to v8.10.0

Closes #428

@taylor-swanson taylor-swanson self-assigned this Sep 27, 2023
@taylor-swanson
Update fleet output resource to new API schema format
4c28de0 
- Updated fleet output to use new schema format, where each output
kind now has a strongly typed data structure to hold the relevant
configuration items.
- Relocated the fleet api generators to match repo style, and
cleaned up the schema downloader and filtering functions.
- Expose 'ca_trusted_fingerprint' config value
- Add test case for logstash output
@taylor-swanson taylor-swanson marked this pull request as ready for review September 27, 2023 18:53
@taylor-swanson taylor-swanson requested a review from tobio October 2, 2023 12:35
@tobio
Copy link
Member

tobio commented Oct 2, 2023 •
edited
Loading

@taylor-swanson what happens when this is run against an older Elasticsearch version?

It looks like we're still running the relevant acceptance tests on 8.6+ so I'm assuming there's no compatibility issues?

tobio
tobio approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the BWC question.

@taylor-swanson
Copy link
Contributor Author

@tobio

It looks like we're still running the relevant acceptance tests on 8.6+ so I'm assuming there's no compatibility issues?

That's my understanding as well. The changes to the Fleet OpenAPI schema were to better define the output types and how the output API should be used. As far as I can tell, this doesn't actually change what data we send to the Fleet API. What it did change was the code that was generated, which necessitated this change. Thankfully, we have the acceptance tests running against the different versions to validate things still work.

@tobio tobio merged commit 01694b0 into elastic:main Oct 3, 2023
@taylor-swanson taylor-swanson deleted the update_fleet_output branch October 5, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update elasticstack_fleet_output resource to use new API schema types
2 participants
@taylor-swanson @tobio