Skip to content

Add plugin framework #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 12, 2023
Merged

Add plugin framework #343

merged 15 commits into from
Oct 12, 2023

Conversation

wandergeek
Copy link
Contributor

@wandergeek wandergeek commented May 31, 2023 •
edited by tobio
Loading

Fixes #214

Adds full support for the plugin framework. Adds a resource to import saved objects in Kibana as a POC for using the framework in this provider.

@wandergeek wandergeek self-assigned this May 31, 2023
@tobio tobio force-pushed the O11Y-236-new-plugin-framework branch from bd83e64 to 6c424ae Compare August 21, 2023 12:31
@tobio tobio force-pushed the O11Y-236-new-plugin-framework branch from 91a18fd to 610e4c2 Compare September 6, 2023 11:43
@tobio tobio changed the title Add plugin framework (WIP) Add plugin framework Sep 12, 2023
@tobio tobio requested a review from dimuon September 12, 2023 10:33
@tobio tobio marked this pull request as ready for review September 12, 2023 10:33
@tobio tobio mentioned this pull request Sep 17, 2023
Merged
dimuon
dimuon reviewed Sep 26, 2023
View reviewed changes
dimuon
dimuon reviewed Sep 26, 2023
View reviewed changes
@dimuon
Copy link
Contributor

dimuon commented Sep 28, 2023

@wandergeek , @tobio I reviewed the PR. Thanks for the initiative 👍

@tobio tobio requested a review from dimuon October 9, 2023 02:31
@tobio
Copy link
Member

tobio commented Oct 11, 2023

@dimuon I think I've covered all the points in the PR, are you able to take another look here?

dimuon
dimuon previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

it needs changelog :)

@tobio tobio force-pushed the O11Y-236-new-plugin-framework branch from 88655b1 to aa5916c Compare October 12, 2023 05:45
@tobio tobio requested a review from dimuon October 12, 2023 06:11
@tobio tobio merged commit 536ba29 into elastic:main Oct 12, 2023
@taylor-swanson taylor-swanson mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

@dimuon dimuon Awaiting requested review from dimuon

Assignees

@wandergeek wandergeek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Terraform Plugin Framework
3 participants
@wandergeek @dimuon @tobio