Skip to content

Add alert rule management #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 23, 2023
Merged

Add alert rule management #292

merged 12 commits into from
Mar 23, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Mar 22, 2023

Fixes #48

Adds support for a Kibana alert rule resource. This PR includes a generated Kibana alerting API client which we utilise to manage alert rules.

@tobio tobio requested a review from dimuon March 22, 2023 08:50
@tobio tobio self-assigned this Mar 22, 2023
@tobio tobio force-pushed the alert-rules branch 2 times, most recently from 9047515 to 9eba015 Compare March 22, 2023 08:55
@dimuon
Copy link
Contributor

dimuon commented Mar 22, 2023

@tobio , does it make sense to add description to README with regard to generating Kibana client?

dimuon
dimuon reviewed Mar 22, 2023
View reviewed changes
dimuon
dimuon reviewed Mar 22, 2023
View reviewed changes
dimuon
dimuon reviewed Mar 22, 2023
View reviewed changes
@dimuon
Copy link
Contributor

dimuon commented Mar 22, 2023

👍 It looks good besides some nits. Also it can be helpful to have unit tests for covering data transformations like TF <-> internal model <-> client request.

dimuon
dimuon previously approved these changes Mar 22, 2023
View reviewed changes
@tobio @dimuon
Apply suggestions from code review
70488e9 
Co-authored-by: Dmitry Onishchenko <[email protected]>
tobio added 3 commits March 23, 2023 10:32
@tobio
Merge remote-tracking branch 'origin/main' into alert-rules
617be68 
* origin/main:
  [ISSUE-154] Add Watches (#155)
  Bump actions/setup-go from 3 to 4 (#288)
  Enrich Policy Resource (#286)
@tobio
CHANGELOG.md
3bcb6d7
@tobio
Fix acceptance tests
dbcd92b
dimuon
dimuon approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobio tobio merged commit 2b08097 into main Mar 23, 2023
@tobio tobio deleted the alert-rules branch March 23, 2023 22:17
@jsangilve jsangilve mentioned this pull request Mar 30, 2023
Closed
This was referenced Apr 12, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for Alerts
2 participants
@tobio @dimuon