Skip to content

Support Kibana connections #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 30, 2023
Merged

Support Kibana connections #226

merged 30 commits into from
Jan 30, 2023

Conversation

webfella
Copy link

@webfella webfella commented Dec 14, 2022 •
edited
Loading

Adds support for Kibana within the provider connection block.

@webfella webfella self-assigned this Dec 14, 2022
tobio
tobio reviewed Dec 14, 2022
View reviewed changes
@tobio tobio mentioned this pull request Dec 19, 2022
Closed
1 task
@webfella webfella marked this pull request as ready for review January 18, 2023 05:21
tobio
tobio reviewed Jan 23, 2023
View reviewed changes
tobio
tobio previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll get some acceptance tests around this with the initial Kibana resources.

tobio
tobio reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog entry for this one since there's a bunch of changes to how the ES connection is built.

tobio
tobio approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time may change me
But I can't trace time

@webfella webfella merged commit da849cf into elastic:main Jan 30, 2023
@webfella webfella deleted the support-kibana-connection branch January 30, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@webfella webfella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfella @tobio