Skip to content

Dry up NewApiClient #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 8, 2022
Merged

Dry up NewApiClient #220

merged 6 commits into from
Dec 8, 2022

Conversation

webfella
Copy link

@webfella webfella commented Dec 7, 2022

NewApiClient now returns diag.Diagnostics instead of error, and the shared code with NewApiClientFunc has been abstracted out to newEsApiClient.

Closes #203

@webfella webfella requested a review from tobio December 7, 2022 08:44
@webfella webfella self-assigned this Dec 7, 2022
tobio
tobio reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, some minor nits.

tobio
tobio approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@webfella webfella merged commit 037edca into elastic:main Dec 8, 2022
@webfella webfella deleted the dry-up-NewApiClient branch December 8, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@webfella webfella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRY up the elasticsearch connection schema and client construction.
2 participants
@webfella @tobio