Skip to content

Update dependencies #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Update dependencies #139

merged 6 commits into from
Sep 12, 2022

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Sep 12, 2022

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@k-yomo k-yomo force-pushed the update-dependencies branch from 9956075 to 49847fb Compare September 12, 2022 06:47
@tobio
Copy link
Member

tobio commented Sep 12, 2022

jenkins test this

@k-yomo
Copy link
Contributor Author

k-yomo commented Sep 12, 2022

Lint was failing with false positive case. I updated the golangci-lint version and refactored to pass the lint.

20:47:27  internal/clients/api_client.go:48:11: undeclared name: `elasticsearch` (typecheck)
20:47:27  	es      *elasticsearch.Client

@tobio
Could you run the tests again?🙏

@tobio
Copy link
Member

tobio commented Sep 12, 2022

jenkins test this

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit d0af7b6 into elastic:main Sep 12, 2022
@k-yomo k-yomo deleted the update-dependencies branch September 12, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants