Skip to content

Additional dataview field formats #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 10, 2025
Merged

Conversation

daemitus
Copy link
Contributor

@daemitus daemitus commented Feb 3, 2025

This mostly comes from a coworker who noticed I had touched the kbapi generator.

  • Since the dataview field_format params are explicily defined, rather than another big jsonencode() block, we get to add all these fields manually.
  • Updated the transform script to add all the missing dataview field format params
  • Updated the transform script to allow for arbitrary github refs rather than just head/main.
  • Using said github_ref, pulled 2024-11-19 (close to when I originally PR'd the whole thing), which pulled in one new field that needed handling (in agent policies, required_versions) by adding an omit-empty.
  • Added -f to the kbapi curl command, was getting silent 429 errors
  • A bunch of tests/docs to support all the params.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for thing folks!

@tobio tobio merged commit b1caa1e into elastic:main Feb 10, 2025
22 checks passed
@daemitus daemitus deleted the dataview-field-formats branch March 19, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants