Skip to content

ESQL: Fix lookup optimizer tests on release #118742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alex-spies
Copy link
Contributor

Fix #118721

  • Skip corresponding optimizer tests if LOOKUP JOIN is disabled.
  • Enable LogicalPlanOptimizerTests again.

@alex-spies alex-spies added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Dec 16, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-spies alex-spies added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 16, 2024
@elasticsearchmachine elasticsearchmachine merged commit bb8503a into elastic:main Dec 16, 2024
16 checks passed
@alex-spies alex-spies deleted the fix-lookup-optimizer-tests-on-release branch December 16, 2024 10:22
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118742

@alex-spies
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Dec 16, 2024
Fix elastic#118721

* Skip corresponding optimizer tests if `LOOKUP JOIN` is disabled.
* Enable LogicalPlanOptimizerTests again.

(cherry picked from commit bb8503a)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Dec 16, 2024
Fix #118721

* Skip corresponding optimizer tests if `LOOKUP JOIN` is disabled.
* Enable LogicalPlanOptimizerTests again.

(cherry picked from commit bb8503a)

# Conflicts:
#	muted-tests.yml
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…#118750)

Fix elastic#118721

* Skip corresponding optimizer tests if `LOOKUP JOIN` is disabled.
* Enable LogicalPlanOptimizerTests again.

(cherry picked from commit bb8503a)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] LogicalPlanOptimizerTests class failing
3 participants