Add Lucene 9.12.1 index version constant #118557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>non-issue
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ChrisHegarty
commented
Dec 12, 2024
| @@ -133,6 +133,7 @@ private static Version parseUnchecked(String version) { | |||
| public static final IndexVersion TIME_BASED_K_ORDERED_DOC_ID_BACKPORT = def(8_520_00_0, Version.LUCENE_9_12_0); | |||
| public static final IndexVersion V8_DEPRECATE_SOURCE_MODE_MAPPER = def(8_521_00_0, Version.LUCENE_9_12_0); | |||
| public static final IndexVersion USE_SYNTHETIC_SOURCE_FOR_RECOVERY_BACKPORT = def(8_522_00_0, Version.LUCENE_9_12_0); | |||
| public static final IndexVersion UPGRADE_TO_LUCENE_9_12_1 = def(8_523_00_0, parseUnchecked("9.12.1")); | |||
There was a problem hiding this comment.
We use parseUnchecked here as a temporary measure. Lucene 10.0 does not have the 9.12.1 version constant, the upcoming Lucene 10.1 will. (see apache/lucene#14060)
javanna
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the IndexVersion constant for Lucene 9.12.1. Since main is already on Lucene 10, this change trivially just ensures that the constant version value in main is the same as that in the 8.x branch.
relates #118300