Correcting the index version filter in migration reindex logic #118487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
backport pending
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
| * The version before which we do not support writes in the _next_ major version of Elasticsearch. For example, Elasticsearch 10.x will | ||
| * not support writing to indices created before version 9.0.0. | ||
| */ | ||
| private static final IndexVersion MINIMUM_WRITEABLE_VERSION_AFTER_UPGRADE = IndexVersions.UPGRADE_TO_LUCENE_10_0_0; |
There was a problem hiding this comment.
Good explanation and naming 👍
| * This predicate allows through only indices that were created with a previous lucene version, meaning that they need to be reindexed | ||
| * in order to be writable in the _next_ lucene version. | ||
| */ | ||
| public static Predicate<Index> getOldIndexVersionPredicate(Metadata metadata) { |
There was a problem hiding this comment.
nit: maybe change predicate name to hasOldIndexVersion
There was a problem hiding this comment.
Err maybe not. I see that the current naming is meant to explain that you are making a predicate from the metadata
parkertimmins
approved these changes
Dec 11, 2024
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Dec 11, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 11, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…ic#118487) (elastic#118503) * Correcting the index version filter in migration reindex logic (elastic#118487) * fixing the version for 8.x
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…ic#118487) (elastic#118503) * Correcting the index version filter in migration reindex logic (elastic#118487) * fixing the version for 8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the index version filter in the migration reindex logic. We want to require reindexing of indices if they were created before the current version, because those indices will not be writable in the next version. So for Elasticsearch 9, we want to return any indices created before Elasticsearch 9 because those will not be writable in Elasticsearch 10. When this is backported to 8.18 we will want to change this version to Elasticsearch 8.0.0 because Elasticsearch 9 will not support writing to any indices created before 8.0.0.