Skip to content

Disable check_on_startup for KibanaUserRoleIntegTests #118428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jfreden
Copy link
Contributor

@jfreden jfreden commented Dec 11, 2024

Resolves: #113592, #113593

The tests try to create an index (logstash-20-12-2015):

14:18:18: [2024-09-26T14:18:18,859][INFO ][o.e.i.KibanaUserRoleIntegTests] [testFieldMappings] Index [1] docs async: [true] bulk: [false]

Then seeing a bunch of:

  1> [2024-09-26T14:18:25,581][WARN ][o.e.i.s.IndexShard       ] [node_s0] [logstash-20-12-2015][0] performing expensive diagnostic checks during shard startup [index.shard.check_on_startup=true]; these checks should only be enabled temporarily, you must remove this index setting as soon as possible
  1> [2024-09-26T14:18:26,029][WARN ][o.e.i.s.IndexShard       ] [node_s0] [logstash-20-12-2015][1] performing expensive diagnostic checks during shard startup [index.shard.check_on_startup=true]; these checks should only be enabled temporarily, you must remove this index setting as soon as possible
  1> [2024-09-26T14:18:26,631][WARN ][o.e.i.s.IndexShard       ] [node_s0] [logstash-20-12-2015][2] performing expensive diagnostic checks during shard startup [index.shard.check_on_startup=true]; these checks should only be enabled temporarily, you must remove this index setting as soon as possible
  1> [2024-09-26T14:18:27,422][WARN ][o.e.i.s.IndexShard       ] [node_s0] [logstash-20-12-2015][3] performing expensive diagnostic checks during shard startup [index.shard.check_on_startup=true]; these checks should only be enabled temporarily, you must remove this index setting as soon as possible

These warnings appear to be spread out over a pretty long period of time and is likely what causes the timeout.

This PR disables the INDEX_CHECK_ON_STARTUP to make sure the tests do not time out.

@jfreden jfreden added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label labels Dec 11, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Dec 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Nice find!

Edit: I think we should backport this fix as it was reported for main branch, back in September .

@jfreden jfreden added v8.18.0 auto-backport Automatically create backport pull requests when merged labels Dec 12, 2024
@jfreden jfreden merged commit c30ba12 into elastic:main Dec 12, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118428

jfreden added a commit to jfreden/elasticsearch that referenced this pull request Dec 12, 2024
(cherry picked from commit c30ba12)

# Conflicts:
#	muted-tests.yml
@jfreden
Copy link
Contributor Author

jfreden commented Dec 12, 2024

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
…#118532)

* Disable check_on_startup for KibanaUserRoleIntegTests (#118428)

(cherry picked from commit c30ba12)

# Conflicts:
#	muted-tests.yml

* fixup! Unmute test
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…118428) (elastic#118532)

* Disable check_on_startup for KibanaUserRoleIntegTests (elastic#118428)

(cherry picked from commit c30ba12)

# Conflicts:
#	muted-tests.yml

* fixup! Unmute test
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…118428) (elastic#118532)

* Disable check_on_startup for KibanaUserRoleIntegTests (elastic#118428)

(cherry picked from commit c30ba12)

# Conflicts:
#	muted-tests.yml

* fixup! Unmute test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] KibanaUserRoleIntegTests testFieldMappings failing
3 participants