Skip to content

[8.16] Fix ProfileIntegTests (#117888) #118059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Dec 5, 2024

Backports the following commits to 8.16:

The test setup for `ProfileIntegTests` is flawed, where the full name of
a user can be a substring of other profile names (e.g., `SER` is a
substring of `User <random-string>-space1`) -- when that's passed into
suggest call with the `*` space, we get a match on all profiles, instead
of only the one profile expected in the test, since we are matching on
e.g. `SER*`. This PR restricts the setup to avoid the wildcard profile
for that particular test.

Closes: elastic#117782
@n1v0lg n1v0lg added :Security/Profile User Profiles & Personalisation >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Security Meta label for security team labels Dec 5, 2024
@elasticsearchmachine elasticsearchmachine merged commit 187aecf into elastic:8.16 Dec 16, 2024
20 checks passed
@n1v0lg n1v0lg deleted the backport/8.16/pr-117888 branch December 16, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Security/Profile User Profiles & Personalisation Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.16.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants