Skip to content

Add Mistral inference details #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Add Mistral inference details #3997

merged 2 commits into from
Mar 25, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 18, 2025

Relates to #3821

This PR adds the Mistral inference use case, with content derived from https://www.elastic.co/guide/en/elasticsearch/reference/8.18/infer-service-mistral.html

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_mistral Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review March 18, 2025 04:35
@lcawl lcawl requested a review from a team as a code owner March 18, 2025 04:35
@lcawl lcawl requested a review from a team March 25, 2025 17:29
Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍷

@lcawl lcawl force-pushed the inference-mistral branch from 2079ad3 to f0662e6 Compare March 25, 2025 19:28
@lcawl lcawl enabled auto-merge (squash) March 25, 2025 19:29
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_mistral Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit f7c35e7 into main Mar 25, 2025
8 checks passed
@lcawl lcawl deleted the inference-mistral branch March 25, 2025 19:29
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3997-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7c35e7b15bce19824df74e7628f4160f6de65aa
# Push it to GitHub
git push --set-upstream origin backport-3997-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3997-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3997-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7c35e7b15bce19824df74e7628f4160f6de65aa
# Push it to GitHub
git push --set-upstream origin backport-3997-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3997-to-8.18.

Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-3997-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7c35e7b15bce19824df74e7628f4160f6de65aa
# Push it to GitHub
git push --set-upstream origin backport-3997-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-3997-to-9.0.

lcawl added a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit f7c35e7)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 25, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit f7c35e7)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 25, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit f7c35e7)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 25, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 25, 2025
lcawl added a commit that referenced this pull request Mar 25, 2025
lcawl added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants