Fix for issue #209 #230
Merged
Fix for issue #209 #230
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same way we do with Hash
|
Looks good to me. Is it possible to add a failing spec for this? |
|
Good call -- done. Will squash and merge. |
| expect(@o.keyword_args_hello(&:upcase)).to eq("Hey, ADIT!") | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
These tests need to go to ruby-specific tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was, the arguments to
KeywordArgsare optional. So if they are not provided, the params and contracts don't line up correctly.becomes
Fix is in this commit. Could you review @waterlink ?
cc @rap-kasta