Skip to content

feat: Add delete one message or many messages feature for published a… #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ustaserdar
Copy link

…nd received messages

Description:

This pull request adds a "Delete" button to the dashboard screen, allowing users to delete events that are in the "Succeeded" or "Failed" state, either individually or in bulk. This feature improves user experience by enabling easier cleanup of completed or failed events from the UI.

Issue(s) addressed:

  • There is no related issue

Changes:

  • Added a "Delete" button to the dashboard UI.
  • Enabled multi-selection of events for bulk deletion.
  • Deletion is only available for events in "Succeeded" or "Failed" state.
  • UI updates automatically after deletion to reflect the changes.

Affected components:

  • Dashboard screen
  • Event listing and filtering logic
  • Event deletion service (API or related logic, if applicable)

How to test:

  • Run the application locally.
  • Navigate to the Received or Published dashboard screen.
  • Select one or more events with "Succeeded" or "Failed" status.
  • Click the "Delete" button to remove them.
  • Confirm that the deleted events are removed from the UI and backend.
  • Verify that events with "Pending" status cannot be deleted.

Checklist:

  • I have tested my changes locally
  • I have added necessary documentation (if applicable)
  • I have updated the relevant tests (if applicable)
  • My changes follow the project's code style guidelines

Reviewers:

Copy link
Member

@yang-xiaodong yang-xiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you for your PR. It looks good!
But we may have to merge this PR in the next minor version because it involves the addition of features and the change of Api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants