Skip to content

Port dotnet/sdk SourceBuild patches from dotnet/installer #22281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Oct 22, 2021 · 5 comments
Closed

Port dotnet/sdk SourceBuild patches from dotnet/installer #22281

eerhardt opened this issue Oct 22, 2021 · 5 comments

Comments

@eerhardt
Copy link
Member

eerhardt commented Oct 22, 2021

In order to get OmniSharp working with a source-built .NET SDK, we need to build Microsoft.NET.Build.Tasks for netfx. However, we have some code that explicitly removes these assemblies from building for netfx:

<TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks>

<TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks>

This causes OmniSharp to not work with a 6.0 source-built SDK.

In order to work around this for source-build, we are introducing a patch for 6.0.0. We should port these patches into the dotnet/sdk repo proper.

@sfoslund
Copy link
Member

@eerhardt what is the timeline on this change, do we need to make it for 6.0.2xx?

@sfoslund sfoslund added this to the 6.0.2xx milestone Oct 26, 2021
@sfoslund sfoslund added source-build and removed untriaged Request triage from a team member labels Oct 26, 2021
@sfoslund sfoslund removed their assignment Oct 26, 2021
@eerhardt
Copy link
Member Author

I don't know what kinds of changes are accepted into servicing, but my opinion is that we should remove these SourceBuild patches as soon as we can after 6.0 is out the door. I would have made them in the 6.0.1xx branch if it wasn't so close to the release.

So my opinion is that we should take this into 6.0.1xx in the first servicing release after 6.0.100 is released.

MichaelSimons pushed a commit to MichaelSimons/sdk that referenced this issue Jan 5, 2022
Required for omnisharp to work with a source-built .NET SDK.

Patch removal issue: dotnet#22281
MichaelSimons added a commit that referenced this issue Jan 18, 2022
Required for omnisharp to work with a source-built .NET SDK.

Patch removal issue: #22281

Co-authored-by: Eric Erhardt <[email protected]>
@marcpopMSFT
Copy link
Member

@MichaelSimons is this done now and can be closed?

@marcpopMSFT marcpopMSFT modified the milestones: 6.0.2xx, 6.0.3xx Feb 2, 2022
@marcpopMSFT
Copy link
Member

@MichaelSimons?

@MichaelSimons
Copy link
Member

Yes - done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants