-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Port dotnet/sdk SourceBuild patches from dotnet/installer #22281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@eerhardt what is the timeline on this change, do we need to make it for 6.0.2xx? |
I don't know what kinds of changes are accepted into servicing, but my opinion is that we should remove these SourceBuild patches as soon as we can after 6.0 is out the door. I would have made them in the So my opinion is that we should take this into |
Required for omnisharp to work with a source-built .NET SDK. Patch removal issue: dotnet#22281
Required for omnisharp to work with a source-built .NET SDK. Patch removal issue: #22281 Co-authored-by: Eric Erhardt <[email protected]>
@MichaelSimons is this done now and can be closed? |
Yes - done. |
In order to get OmniSharp working with a source-built .NET SDK, we need to build Microsoft.NET.Build.Tasks for netfx. However, we have some code that explicitly removes these assemblies from building for netfx:
sdk/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj
Lines 15 to 16 in 7bffe25
sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj
Lines 18 to 19 in 7bffe25
This causes OmniSharp to not work with a 6.0 source-built SDK.
In order to work around this for source-build, we are introducing a patch for
6.0.0
. We should port these patches into the dotnet/sdk repo proper.The text was updated successfully, but these errors were encountered: