Skip to content

Fix roslyn to build with boostrapped build #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fix roslyn to build with boostrapped build #12500

merged 1 commit into from
Oct 25, 2021

Conversation

dseefeld
Copy link

@dseefeld dseefeld commented Oct 23, 2021 •
edited by MichaelSimons
Loading

Switch roslyn build to build with .slnf file to exclude projects with <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">. This enables roslyn to be built with a bootstrapped source-built SDK.

Related to dotnet/roslyn#57342

@dseefeld dseefeld requested a review from a team as a code owner October 23, 2021 01:42
@dseefeld dseefeld marked this pull request as draft October 23, 2021 02:57
@dagood
Copy link
Member

dagood commented Oct 23, 2021

Potential alternative: create a stub Microsoft.NET.Sdk.WindowsDesktop and use the SourceBuiltSdkResolver to redirect the projects to it. This could be lower-maintenance than a solution filter.

@dseefeld dseefeld marked this pull request as ready for review October 25, 2021 14:51
eerhardt
eerhardt approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagood dagood mentioned this pull request Oct 25, 2021
Closed
@MichaelSimons MichaelSimons merged commit 9cf82e2 into dotnet:release/6.0.1xx Oct 25, 2021
@dseefeld dseefeld deleted the bootstrapRoslyn branch November 17, 2021 21:11
@MichaelSimons MichaelSimons mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crummel crummel crummel approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@eerhardt eerhardt eerhardt approved these changes

@dagood dagood dagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dseefeld @dagood @crummel @MichaelSimons @eerhardt