Skip to content

Dispose Scalars implicitly created in Tensor operators #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dispose Scalars implicitly created in Tensor operators #1434

wants to merge 2 commits into from

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Jan 10, 2025

This pull request modifies the Tensor operators involving primitives to immediately dispose the Scalar object they create, rather than waiting for the garbage collector.

@ds5678
Copy link
Contributor Author

ds5678 commented Jan 10, 2025

@dotnet-policy-service agree

@ds5678 ds5678 force-pushed the dispose-implicitly-converted-scalars branch from 273f174 to ff6ffd7 Compare April 4, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yueyinqiu yueyinqiu yueyinqiu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds5678 @yueyinqiu