-
Notifications
You must be signed in to change notification settings - Fork 195
Autocast #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Autocast #1235
Conversation
@dotnet-policy-service agree |
int8_t THSTorch_get_autocast_gpu_dtype() | ||
{ | ||
//TODO: Implement AUTOCAST AMP AND GRADSCALER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a work-in-progress PR, or something you're submitting for approval and merging? If the latter, then please create an issue to track "to do" items and add some unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U can merging this if you want, this dont break anything (far as I know). But may useful for someone who want use that autocast function manually. My idea and plan is to make AMP, GradScaler, these modules use the functions I added.
Thank, I will try take into account about issue "to do" and unit tests. Sorry.
@haytham2597 -- thank you for your first PR! Much appreciated. Please see the comment I made in the review. |
Do not merge, i keep have some issue. |
Lots of errors in the build on everything except the .NET FX builds (which don't have System.Range): |
I am very happy to see this proposal. |
@haytham2597 -- just a gentle ping! I think this PR would be very valuable, but it's still a draft, and thus I will not merge it. I also had some comments in my review. |
Yeah, but sorry i am very busy with studied and work. I need managed very well about my time for making some progress on this pull requests, i mean this is very useful for me too.
torch.Tensor a;
using(var ac = torch.NewAutocast()){
torch.Tensor b = a;
torch.Tensor c = torch.arange(...)
} The The idea Is very similar that you do with using (var d = torch.NewDisposeScope()) And in outer scope need back to original dtype. Because the neural should backward with original dtype (on my understood) |
Yeah, no pressure! We all have other things to do, so I understand completely. Just wanted to let you know we haven't forgotten about your work, and that it will be appreciated, if and when you find time. |
I would also like to see this completed. It should help with #1136 as well. |
Really need this!! Thank you!! |
About AMP or Autocast, @NiklasGustafsson do you have any idea what the "only" (or more abstraction) method is to obtain the tensor? Because in autocast for example, inner-scope on Autocast should all tensors pass to Float16, So the problem is Tensor have so much operation (ie: sum, prod, some linalg, div, etc.) And i should in every method cast the tensor to specific ScalarType. But I want to see where is one method for that, I thinking about using the IntPtr of Tensor and each call of this (because some method uses that, like prod, sum, etc use that IntPtr) and casting to that ScalarType. Is best idea work with IntPtr tensor right? P.D: I don't know why i can Compile but cannot run Test so rare. |
This PR is still labeled 'Draft' -- how close do you think you're getting to having it ready to review and merge? |
I am closest but not enough. I need write and Test the TODO:
|
Any update? |
Soon i will try make AMP (Automatic Mixed Precision) with GradScaler.